[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-07-11 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 5: This change does break binary compatibility. We

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-10 Thread Anonymous Coward (Code Review)
Hello Brian McDevitt, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12949 to look at the new patch set (#4). Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-10 Thread Anonymous Coward (Code Review)
Hello Brian McDevitt, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12949 to look at the new patch set (#3). Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 3: (2 comments)

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-10 Thread Anonymous Coward (Code Review)
Hello Brian McDevitt, Kudu Jenkins, Adar Dembo, Grant Henke, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12949 to look at the new patch set (#2). Change subject: KUDU-2689: Made PartialRow setters use a fluent-style.

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-10 Thread Anonymous Coward (Code Review)
raym...@phdata.io has abandoned this change. ( http://gerrit.cloudera.org:8080/12952 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Abandoned Abandoning redundant change. -- To view, visit

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-09 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: > Agreed. Is there something off the shelf we

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12952 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 2: Seems like you uploaded two changes for the same

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: (2 comments) > Changing a void method to return

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-08 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12952 to look at the new patch set (#2). Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. ..

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-07 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: Changing a void method to return a value would

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-05 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 ) Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. Patch Set 1: Is this ABI-compatible? (do we have a documented

[kudu-CR] KUDU-2689: Made PartialRow setters use a fluent-style.

2019-04-05 Thread Anonymous Coward (Code Review)
raym...@phdata.io has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12949 Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. .. KUDU-2689: Made PartialRow setters use a fluent-style.