[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change.  ( 
http://gerrit.cloudera.org:8080/13877 )

Change subject: KUDU-2797 p1: expose the tablet's live row count
..


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 3
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13877 )

Change subject: KUDU-2797 p1: expose the tablet's live row count
..


Patch Set 3: Verified+1 Code-Review+2

Failure was unrelated.


--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 3
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 18 Jul 2019 22:20:06 +
Gerrit-HasComments: No


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-18 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13877 )

Change subject: KUDU-2797 p1: expose the tablet's live row count
..

KUDU-2797 p1: expose the tablet's live row count

The tablet's live row count is exposed in below ways:
1) be exposed as metrics on the tablet server;
2) be exposed on the tablet server's Web-UI;

Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Reviewed-on: http://gerrit.cloudera.org:8080/13877
Reviewed-by: Adar Dembo 
Tested-by: Adar Dembo 
---
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tserver_path_handlers.cc
M www/tablet.mustache
5 files changed, 61 insertions(+), 2 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 4
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-17 Thread helifu (Code Review)
Hello Kudu Jenkins, Adar Dembo,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13877

to look at the new patch set (#3).

Change subject: KUDU-2797 p1: expose the tablet's live row count
..

KUDU-2797 p1: expose the tablet's live row count

The tablet's live row count is exposed in below ways:
1) be exposed as metrics on the tablet server;
2) be exposed on the tablet server's Web-UI;

Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
---
M src/kudu/tablet/tablet_replica-test.cc
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tserver_path_handlers.cc
M www/tablet.mustache
5 files changed, 61 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/13877/3
--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 3
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13877 )

Change subject: KUDU-2797 p1: expose the tablet's live row count
..


Patch Set 2: -Code-Review

Actually, could you add a unit test that verifies the metric values?


--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 2
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Jul 2019 16:23:52 +
Gerrit-HasComments: No


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13877 )

Change subject: KUDU-2797 p1: expose the tablet's live row count
..


Patch Set 2: Code-Review+2


--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 2
Gerrit-Owner: helifu 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 17 Jul 2019 16:23:37 +
Gerrit-HasComments: No


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-17 Thread helifu (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change. Please visit

http://gerrit.cloudera.org:8080/13877

to look at the new patch set (#2).

Change subject: KUDU-2797 p1: expose the tablet's live row count
..

KUDU-2797 p1: expose the tablet's live row count

The tablet's live row count is exposed in below ways:
1) be exposed as metrics on the tablet server;
2) be exposed on the tablet server's Web-UI;

Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
---
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tserver_path_handlers.cc
M www/tablet.mustache
4 files changed, 36 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/13877/2
--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 2
Gerrit-Owner: helifu 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] KUDU-2797 p1: expose the tablet's live row count

2019-07-17 Thread helifu (Code Review)
helifu has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/13877


Change subject: KUDU-2797 p1: expose the tablet's live row count
..

KUDU-2797 p1: expose the tablet's live row count

The tablet's live row count is exposed in below ways:
1) be exposed as metrics on the tablet server;
2) be exposed on the tablet server's Web-UI;

Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
---
M src/kudu/tablet/tablet_replica.cc
M src/kudu/tablet/tablet_replica.h
M src/kudu/tserver/tserver_path_handlers.cc
M www/tablet.mustache
4 files changed, 34 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/13877/1
--
To view, visit http://gerrit.cloudera.org:8080/13877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b15d7d2a5c84a3716215608b2444395ca94e64c
Gerrit-Change-Number: 13877
Gerrit-PatchSet: 1
Gerrit-Owner: helifu