[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support tombstoned voting This patch makes it possible for tombstoned tablet replicas to vote in Raft

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: I did an analysis of failed raft_consensus-itest failures before and after this patch. There was no change in

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6960 To unsubscribe, visit

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Well, actually, let me hit raft_consensus-itest a little harder. It's possible that I made it flaky and

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: The new tests still look good. 100% reliable after 100 loops w/ TSAN + 8x stress: tombstoned_voting-itest:

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: > lgtm. Did you do any last test loop of the relevant tests after the > latest round of changes? Thanks for

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6960 To unsubscribe, visit

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 13: Code-Review+1 lgtm. Did you do any last test loop of the relevant tests after the latest round of changes?

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 12: (2 comments)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#13). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#12). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#11). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-23 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (29 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-22 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (12 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/integration-tests/cluster_itest_util.h

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (6 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: (9 comments) http://gerrit.cloudera.org:8080/#/c/6960/10/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 10: I think the failure was caused by already-flaky java tests but I am investigating. I'd like to figure out how

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-21 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#10). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-18 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#9). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-18 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#8). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-18 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/6960/7/src/kudu/tserver/tablet_service.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-17 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-17 Thread Mike Percy (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#7). Change subject: KUDU-871. Support tombstoned voting

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-15 Thread Edward Fancher (Code Review)
Edward Fancher has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (1 comment)

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (7 comments) Glanced through one of the tests. Will take a closer look today.

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-10 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (25 comments) http://gerrit.cloudera.org:8080/#/c/6960/6/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6960/6/src/kudu/tablet/tablet_replica.h File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-10 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 6: (7 comments) leaving for luch, more comments forthcoming

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#6). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#5). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 4: (32 comments) http://gerrit.cloudera.org:8080/#/c/6960/4/src/kudu/consensus/raft_consensus.cc File

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-08 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-871. Support tombstoned voting .. Patch Set 4: (21 comments) did a first pass, probably will have more comments after a second pass but figured I'd send

[kudu-CR] KUDU-871. Support tombstoned voting

2017-08-07 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6960 to look at the new patch set (#4). Change subject: KUDU-871. Support tombstoned voting .. KUDU-871. Support