[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Make tcmalloc heap sampling more useful Previously our /pprof/heap

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 3: Errant ??- what I mean is I checked it builds on macOS -- To

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-22 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 3: Code-Review+2 Builds on macOS ✔️ -- To view, visit

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-13 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9263 to look at the new patch set (#3). Change subject: Make tcmalloc heap sampling more useful .. Make

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: (3 comments)

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: > You're telling me you can't symbolize addresses in your

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: > Is that because it's macOS? If not, how does one read that?

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-13 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9263 ) Change subject: Make tcmalloc heap sampling more useful .. Patch Set 2: (3 comments) I tried this out on my macOS system and the heap

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-09 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9263 to look at the new patch set (#2). Change subject: Make tcmalloc heap sampling more useful .. Make

[kudu-CR] Make tcmalloc heap sampling more useful

2018-02-08 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9263 to review the following change. Change subject: Make tcmalloc heap sampling more useful .. Make tcmalloc heap