[kudu-CR] Remove redundant references of MasterServiceProxy

2019-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14047 )

Change subject: Remove redundant references of MasterServiceProxy
..


Patch Set 1: Verified+1 Code-Review+2

For future reference, this kind of single-line cosmetic fix can be merged with 
a larger patch. Usually we might ask to split out cosmetic changes like this 
because a large number of cosmetic changes can be distracting in review. On the 
other hand, for such a small change, keeping it in with a larger change isn't 
as distracting.


--
To view, visit http://gerrit.cloudera.org:8080/14047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6b73b347c566b0f93130b775dac15b646d0219a
Gerrit-Change-Number: 14047
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 12 Aug 2019 18:19:41 +
Gerrit-HasComments: No


[kudu-CR] Remove redundant references of MasterServiceProxy

2019-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/14047 )

Change subject: Remove redundant references of MasterServiceProxy
..

Remove redundant references of MasterServiceProxy

Change-Id: Ie6b73b347c566b0f93130b775dac15b646d0219a
Reviewed-on: http://gerrit.cloudera.org:8080/14047
Reviewed-by: Andrew Wong 
Tested-by: Andrew Wong 
---
M src/kudu/tools/tool_action_master.cc
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Andrew Wong: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/14047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6b73b347c566b0f93130b775dac15b646d0219a
Gerrit-Change-Number: 14047
Gerrit-PatchSet: 2
Gerrit-Owner: honeyhexin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] Remove redundant references of MasterServiceProxy

2019-08-12 Thread Andrew Wong (Code Review)
Andrew Wong has removed a vote on this change.

Change subject: Remove redundant references of MasterServiceProxy
..


Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/14047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie6b73b347c566b0f93130b775dac15b646d0219a
Gerrit-Change-Number: 14047
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: Kudu Jenkins (120)


[kudu-CR] Remove redundant references of MasterServiceProxy

2019-08-12 Thread honeyhexin (Code Review)
honeyhexin has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/14047


Change subject: Remove redundant references of MasterServiceProxy
..

Remove redundant references of MasterServiceProxy

Change-Id: Ie6b73b347c566b0f93130b775dac15b646d0219a
---
M src/kudu/tools/tool_action_master.cc
1 file changed, 0 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14047/1
--
To view, visit http://gerrit.cloudera.org:8080/14047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6b73b347c566b0f93130b775dac15b646d0219a
Gerrit-Change-Number: 14047
Gerrit-PatchSet: 1
Gerrit-Owner: honeyhexin