[kudu-CR] ensure every gflag is defined outside of a namespace

2016-09-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: ensure every gflag is defined outside of a namespace .. ensure every gflag is defined outside of a namespace The gflags docs recommend that all gflags be

[kudu-CR] ensure every gflag is defined outside of a namespace

2016-09-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: ensure every gflag is defined outside of a namespace .. Patch Set 3: Verified+1 Overriding Jenkins, flaky ITClient test. Also ignoring Tidy Bot's last comment

[kudu-CR] ensure every gflag is defined outside of a namespace

2016-09-23 Thread Adar Dembo (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4505 to look at the new patch set (#2). Change subject: ensure every gflag is defined outside of a namespace

[kudu-CR] ensure every gflag is defined outside of a namespace

2016-09-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: ensure every gflag is defined outside of a namespace .. Patch Set 1: Code-Review+2 (1 comment) lgtm, not sure what the jenkins failure's about

[kudu-CR] ensure every gflag is defined outside of a namespace

2016-09-21 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4505 to review the following change. Change subject: ensure every gflag is defined outside of a namespace ..