[kudu-CR] tool: feedback from clang-tidy

2016-09-14 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: tool: feedback from clang-tidy
..


Patch Set 1: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/4423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: feedback from clang-tidy

2016-09-14 Thread Todd Lipcon (Code Review) 
Todd Lipcon has posted comments on this change.

Change subject: tool: feedback from clang-tidy
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/4423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: feedback from clang-tidy

2016-09-14 Thread Todd Lipcon (Code Review) 
Todd Lipcon has submitted this change and it was merged.

Change subject: tool: feedback from clang-tidy
..


tool: feedback from clang-tidy

Tidy Bot is going to steal our jobs! [1]

1. https://en.wikipedia.org/wiki/John_Henry_(folklore)

Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
Reviewed-on: http://gerrit.cloudera.org:8080/4423
Reviewed-by: Todd Lipcon 
Tested-by: Todd Lipcon 
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 4 insertions(+), 11 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved; Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/4423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] tool: feedback from clang-tidy

2016-09-14 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: tool: feedback from clang-tidy
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/3431/

-- 
To view, visit http://gerrit.cloudera.org:8080/4423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] tool: feedback from clang-tidy

2016-09-14 Thread Adar Dembo (Code Review) 
Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/4423

to review the following change.

Change subject: tool: feedback from clang-tidy
..

tool: feedback from clang-tidy

Tidy Bot is going to steal our jobs! [1]

1. https://en.wikipedia.org/wiki/John_Henry_(folklore)

Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
---
M src/kudu/tools/tool_action_common.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tools/tool_action_tablet.cc
3 files changed, 4 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4423/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4423
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice35f5735952532d2051ec634fc193d4050d8b68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Todd Lipcon