[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#9). Change subject: WIP: Integration test for replay cache .. WIP: Integration test

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 9: TSAN is failing not because of failing tests but because of a race due to the changes to

[kudu-CR] add table name field to GetTableSchemaResponsePB

2016-06-30 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3542 to review the following change. Change subject: add table name field to GetTableSchemaResponsePB .. add

[kudu-CR] add table name field to GetTableSchemaResponsePB

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: add table name field to GetTableSchemaResponsePB .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2113/ -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#7). Change subject: WIP: Integration test for replay cache .. WIP: Integration test

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2114/ -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 8: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2116/ -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 8: hum, seems like a flake, RaftConsensusITest.TestReplaceChangeConfigOperation will retrigger anyway

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2117/ -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2115/ -- To view, visit

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 1: > (4 comments) > > What releases (if any) are affected by this? None. > >

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 3: (3 comments)

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2119/ -- To view, visit

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 5: (1 comment)

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3477 to look at the new patch set (#5). Change subject: [java-client] refactor AsyncKuduSession ..

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2118/ -- To view, visit

[kudu-CR] add table name field to GetTableSchemaResponsePB

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: add table name field to GetTableSchemaResponsePB .. Patch Set 1: Code-Review+2 Looks fine, but what do you need this for? AFAIK the client code requires table

[kudu-CR] [java client] RPCs can get lost in a TabletClient race

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] RPCs can get lost in a TabletClient race .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3541 To unsubscribe, visit

[kudu-CR] add table name field to GetTableSchemaResponsePB

2016-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: add table name field to GetTableSchemaResponsePB .. Patch Set 1: For a hypothetical client which allows opening tables by ID. -- To view, visit

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3528

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails .. Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-30 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Implement kudu::optional replacement for boost::optional .. Abandoned With boost now part of thirdparty, it doesn't look like there is a strong case for reimplementing

[kudu-CR] Migrate from boost::optional to kudu::optional

2016-06-30 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: Migrate from boost::optional to kudu::optional .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/3513 To unsubscribe, visit

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2121/ -- To view, visit

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3477 to look at the new patch set (#6). Change subject: [java-client] refactor AsyncKuduSession ..

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3477 To unsubscribe, visit

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3528 to look at the new patch set (#2). Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

[kudu-CR] Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix flaky DeleteTableTest.TestAutoTombstoneAfterRemoteBootstrapRemoteFails .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2120/ -- To

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] refactor AsyncKuduSession .. [java-client] refactor AsyncKuduSession This commit refactors how AsyncKuduSession handles buffering

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2122/ -- To

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 6: (3 comments)

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-30 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3388 to look at the new patch set (#6). Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 17: unrelated flake in RemoteKsckTest.TestChecksumTimeout -- To view, visit

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 17: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe,

[kudu-CR](gh-pages) Update docs for 0.9.1

2016-06-30 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3547 to look at the new patch set (#2). Change subject: Update docs for 0.9.1 .. Update docs for 0.9.1

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Make integration tests run in kudu-client, fix one .. Patch Set 1: (1 comment)

[kudu-CR] Add a ResultTracker class that will track server side results

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2134/ -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2136/ -- To view, visit

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2133/ -- To view, visit

[kudu-CR] Integrate the request tracker with the client

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2128/ -- To view, visit

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 7: Build Started

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2132/ -- To view, visit

[kudu-CR] Integrate the result tracker with writes

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2131/ -- To view, visit

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2127/ --

[kudu-CR] master failover-itest: eliminate some flakiness

2016-06-30 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3521 to look at the new patch set (#2). Change subject: master_failover-itest: eliminate some flakiness ..

[kudu-CR] master failover-itest: eliminate some flakiness

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master_failover-itest: eliminate some flakiness .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2123/ -- To view, visit

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Make integration tests run in kudu-client, fix one .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2124/ -- To view, visit

[kudu-CR] deltafile-test: fix TestEmptyFileIsAborted for file block manager

2016-06-30 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3546 to review the following change. Change subject: deltafile-test: fix TestEmptyFileIsAborted for file block manager

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: [java client] Make integration tests run in kudu-client, fix one .. [java client] Make integration tests run in kudu-client, fix one Change-Id:

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Make integration tests run in kudu-client, fix one .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2125/ -- To view, visit

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Make integration tests run in kudu-client, fix one .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3544 To

[kudu-CR](gh-pages) Update docs for 0.9.1

2016-06-30 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3547 to review the following change. Change subject: Update docs for 0.9.1 .. Update docs for 0.9.1 Change-Id:

[kudu-CR](gh-pages) Update docs for 0.9.1

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Update docs for 0.9.1 .. Update docs for 0.9.1 Change-Id: Ida85e4a7b583c6d66e961c3435a6f0bcc363eacc Reviewed-on:

[kudu-CR](gh-pages) Update docs for 0.9.1

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Update docs for 0.9.1 .. Patch Set 2: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3547 To unsubscribe, visit

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Make integration tests run in kudu-client, fix one .. [java client] Make integration tests run in kudu-client, fix one Change-Id:

[kudu-CR] Try again to disable core dumps in some tests

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Try again to disable core dumps in some tests .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2142/ -- To view, visit

[kudu-CR] Try again to disable core dumps in some tests

2016-06-30 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3549 to review the following change. Change subject: Try again to disable core dumps in some tests .. Try again to disable

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Make integration tests run in kudu-client, fix one .. Patch Set 1: (1 comment) Why wasn't this already running? Was the first implementation pushed

[kudu-CR] [java client] Make integration tests run in kudu-client, fix one

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Make integration tests run in kudu-client, fix one .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3544 To

[kudu-CR] deltafile-test: fix TestEmptyFileIsAborted for file block manager

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: deltafile-test: fix TestEmptyFileIsAborted for file block manager .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2138/ -- To view, visit

[kudu-CR] Integrate the result tracker with writes

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 9: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2140/ -- To view, visit

[kudu-CR] Allow to force-override color diagnostics

2016-06-30 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Allow to force-override color diagnostics .. Patch Set 1: Verified+1 Overriding flakiness of a Java test -- To view, visit http://gerrit.cloudera.org:8080/3509

[kudu-CR] deltafile-test: fix TestEmptyFileIsAborted for file block manager

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: deltafile-test: fix TestEmptyFileIsAborted for file block manager .. deltafile-test: fix TestEmptyFileIsAborted for file block manager This should

[kudu-CR] deltafile-test: fix TestEmptyFileIsAborted for file block manager

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: deltafile-test: fix TestEmptyFileIsAborted for file block manager .. Patch Set 1: > Did you verify this fixes with FBM enabled? Yeah, I ran it with

[kudu-CR] master: add read-write lock to serialize operations around elections

2016-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 1: I've been reviewing the test failure and reproducing it locally. I think I

[kudu-CR] master failover-itest: eliminate some flakiness

2016-06-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: master_failover-itest: eliminate some flakiness .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3521 To unsubscribe,

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 2: (2 comments) Should have a test as well for this

[kudu-CR] deltafile-test: fix TestEmptyFileIsAborted for file block manager

2016-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: deltafile-test: fix TestEmptyFileIsAborted for file block manager .. Patch Set 1: Code-Review+2 Did you verify this fixes with FBM enabled? -- To view, visit

[kudu-CR] master: add read-write lock to serialize operations around elections

2016-06-30 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3550 to review the following change. Change subject: master: add read-write lock to serialize operations around elections

[kudu-CR] master: add read-write lock to serialize operations around elections

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: add read-write lock to serialize operations around elections .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2143/ -- To view,

[kudu-CR] Make dist test.py work on a symlinked work directory

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Make dist_test.py work on a symlinked work directory .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2144/ -- To view, visit

[kudu-CR] WIP: Integration test for replay cache

2016-06-30 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Integration test for replay cache .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2126/ -- To view, visit

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 7: Should we change the default buffer size up by an order of magnitude so that users don't experience this