[kudu-CR] Add a way to include request ids in log-dump

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 8: tests failed due to a problem with the mm patch. just a rebase, keeping the +2 -- To view,

[kudu-CR] Integrate the result tracker with writes

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 28: Code-Review+2 rebased this due to a problem with the mm patch. keeping the +2 -- To view,

[kudu-CR] Add a way to include request ids in log-dump

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit

[kudu-CR] WIP: Add garbage collection to ResultTracker

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/3628/5/src/kudu/rpc/result_tracker.cc File

[kudu-CR] WIP: Add garbage collection to ResultTracker

2016-07-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3628/5/src/kudu/rpc/result_tracker.cc File

[kudu-CR] Integrate the result tracker with writes

2016-07-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 28: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit

[kudu-CR] Move the maintenance manager to util

2016-07-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Move the maintenance manager to util .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3656 To unsubscribe, visit

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2494/ -- To view, visit

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3581 to look at the new patch set (#7). Change subject: [c++-client]: cache non-covering ranges in meta cache ..

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-14 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3648 to look at the new patch set (#5). Change subject: KUDU-1311 [master] support adding and dropping range partitions

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2493/ -- To view, visit

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 7: (13 comments) http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/client-test.cc

[kudu-CR] KUDU-1311 [master] support adding and dropping range partitions

2016-07-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1311 [master] support adding and dropping range partitions .. Patch Set 4: (37 comments) http://gerrit.cloudera.org:8080/#/c/3648/4/src/kudu/client/client.cc

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/meta_cache.cc File

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/3581/5/src/kudu/client/client-test.cc File

[kudu-CR] Move the maintenance manager to util

2016-07-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Move the maintenance manager to util .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3656/3/src/kudu/util/maintenance_manager.h File

[kudu-CR] WIP: Add garbage collection to ResultTracker

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/5/src/kudu/rpc/result_tracker.cc File

[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package

2016-07-14 Thread Dinesh Bhat (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3653 to look at the new patch set (#3). Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package

[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2495/ -- To view,

[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package

2016-07-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3653 To

[kudu-CR] rw mutex: prevent recursive use

2016-07-14 Thread Adar Dembo (Code Review)
Hello Dan Burkert, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3641 to look at the new patch set (#6). Change subject: rw_mutex: prevent recursive use .. rw_mutex: prevent recursive

[kudu-CR] rw mutex: prevent recursive use

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2496/ -- To view, visit

[kudu-CR] Move the maintenance manager to util

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Move the maintenance manager to util .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3656/3/src/kudu/util/maintenance_manager.h File

[kudu-CR] Move the maintenance manager to util

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Move the maintenance manager to util .. Move the maintenance manager to util This moves the maintenance manager to util, along with its required

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 32: (2 comments)

[kudu-CR] Add a way to include request ids in log-dump

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 8: Verified+1 unrelated java flakiness. -- To view, visit http://gerrit.cloudera.org:8080/3612

[kudu-CR] Integrate the result tracker with writes

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#33). Change subject: Add integration tests for replay cache with writes .. Add

[kudu-CR] Memory tracking for result tracker

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2498/ -- To view, visit

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 33: Build Started http://104.196.14.100/job/kudu-gerrit/2499/ -- To view, visit

[kudu-CR] WIP: Add garbage collection to ResultTracker

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2497/ -- To view, visit

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2500/ -- To view, visit

[kudu-CR] Memory tracking for result tracker

2016-07-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/3627/9/src/kudu/rpc/result_tracker.cc File

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/6/CMakeLists.txt File CMakeLists.txt: Line 1000: #

[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 3: Code-Review+2 Overriding flakiness due to isolate race condition -- To view,

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [c++-client]: cache non-covering ranges in meta cache .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2501/ -- To view, visit

[kudu-CR] [c++-client]: cache non-covering ranges in meta cache

2016-07-14 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3581 to look at the new patch set (#8). Change subject: [c++-client]: cache non-covering ranges in meta cache ..

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#34). Change subject: Add integration tests for replay cache with writes .. Add

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 34: Build Started http://104.196.14.100/job/kudu-gerrit/2502/ -- To view, visit

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 34: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit

[kudu-CR] Add a way to include request ids in log-dump

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3612 To unsubscribe, visit

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 29: (1 comment) http://gerrit.cloudera.org:8080/#/c/3519/29/src/kudu/rpc/rpc_header.proto File

[kudu-CR](gh-pages) Replace bootstrap with CDN version

2016-07-14 Thread Mike Percy (Code Review)
Hello Misty Stanley-Jones, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3649 to review the following change. Change subject: Replace bootstrap with CDN version .. Replace bootstrap with

[kudu-CR](gh-pages) Replace bootstrap with CDN version

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Replace bootstrap with CDN version .. Patch Set 1: Rendered HTML: http://mpercy.github.io/kudu/ -- To view, visit http://gerrit.cloudera.org:8080/3649 To

[kudu-CR] docs: Fix broken link to Introduction in navbar

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: docs: Fix broken link to Introduction in navbar .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2430/ -- To view, visit

[kudu-CR] docs: Fix broken link to Introduction in navbar

2016-07-14 Thread Mike Percy (Code Review)
Hello Misty Stanley-Jones, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3650 to review the following change. Change subject: docs: Fix broken link to Introduction in navbar .. docs: Fix

[kudu-CR] Make dist test.py work on a symlinked work directory

2016-07-14 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3551 to look at the new patch set (#2). Change subject: Make dist_test.py work on a symlinked work directory .. Make

[kudu-CR] Make dist test.py work on a symlinked work directory

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Make dist_test.py work on a symlinked work directory .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2431/ -- To view, visit

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2472/ -- To view,

[kudu-CR] KUDU-1358 (part 1): master should accept heartbeat even if follower

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1358 (part 1): master should accept heartbeat even if follower .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2473/ -- To view,

[kudu-CR] master: do not delete unknown tablets

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: master: do not delete unknown tablets .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2471/ -- To view, visit

[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package

2016-07-14 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 2: (3 comments)

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-07-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 16: Code-Review+2 -- To view, visit

[kudu-CR] Move the maintenance manager to util

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3656 Change subject: Move the maintenance manager to util .. Move the maintenance manager to util This moves the maintenance manager

[kudu-CR] Add integration tests for replay cache with writes

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 24: (1 comment)

[kudu-CR] master: add assert checks for leader lock

2016-07-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: master: add assert checks for leader_lock .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3642 To unsubscribe, visit

[kudu-CR] rw mutex: prevent recursive use

2016-07-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit

[kudu-CR] KUDU-1374: send full tablet report when new leader master is detected

2016-07-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1374: send full tablet report when new leader master is detected .. Patch Set 5: Verified+1 More chrpath() and isolate failures. -- To view, visit

[kudu-CR] master: fix corruption when AlterTable() races with CreateTable()

2016-07-14 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: master: fix corruption when AlterTable() races with CreateTable() .. master: fix corruption when AlterTable() races with CreateTable() Admittedly, this

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-07-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 26: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe,

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-07-14 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 15: Code-Review+2 (1 comment)

[kudu-CR] Integrate the request tracker with the client

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Integrate the request tracker with the client .. Integrate the request tracker with the client This integrates the request tracker with the

[kudu-CR] KUDU-1530: Update docs about OS X build dependency on Xcode package

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1530: Update docs about OS X build dependency on Xcode package .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2478/ -- To view,

[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2479/ --

[kudu-CR] KUDU-1358 (part 2): heartbeat to every master

2016-07-14 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1358 (part 2): heartbeat to every master .. Patch Set 6: (4 comments)

[kudu-CR] Memory tracking for result tracker

2016-07-14 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#6). Change subject: Memory tracking for result tracker .. Memory tracking for

[kudu-CR] Add a way to include request ids in log-dump

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2441/ -- To view, visit

[kudu-CR] [java client] Integrate with the replay cache

2016-07-14 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 4: (4 comments) looks mostly good, does this still have the side effect of making us not

[kudu-CR] doxygen for C++ client API

2016-07-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#8). Change subject: doxygen for C++ client API .. doxygen for C++ client API If

[kudu-CR] doxygen for C++ client API

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2504/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To

<    1   2