[kudu-CR] Don't use InMemoryEnv in deltafile-test

[Adar Dembo (Code Review)]

Adar Dembo has posted comments on this change.

Change subject: Don't use InMemoryEnv in deltafile-test
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I380249e6a72a93e1fde86a551c9d4d32d35904da
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3243/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1403: // client2tables is assumed populated upon return of the client
 :   // to avoid race condition it is set with in the synchronized 
block
Mind rewriting this as a proper sentence?


-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3243/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1402:   this.client2tablets.put(client, new ArrayList());
Can you add a comment why this is important to do it before exiting the 
synchronized blog?


-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Ted Malaska (Code Review)]

Ted Malaska has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3243

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..

KUDU-1471 NPE in AsyncKuduClient from Spark

Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/3243/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 

[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

[Ted Malaska (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3231

to look at the new patch set (#3).

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..

KUDU-1470 Exceptions on getting a column value should return the column name 
not the column number

Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
---
M java/kudu-client/src/main/java/org/kududb/client/RowResult.java
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3231/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ted Malaska 

[kudu-CR] fix compile error when compiling column_predicate-test.cc

[song bruce zhang (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3233

to look at the new patch set (#8).

Change subject:  fix compile error when compiling column_predicate-test.cc
..

fix compile error when compiling column_predicate-test.cc

 In env : boost 1.57, centos 6.5, it will fail when compiling
 column_predicate-test.cc.
 Specific error messages:
 "gtest-printers.h:245: undefined reference to `std::basic_ostream& boost::operator<< >(std::basic_ostream&, boost::optional const&)`"

 Adding optional_io.hpp into column_predicate.h get another compile error:
 "operator<<: cannot bind lvalue to 'std::basic_ostream&&'"
 write a boost:operator<< in column_predicate.cc , compile succeed.

Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
---
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
2 files changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3233/8
-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 

[kudu-CR] fix compile error when compiling column_predicate-test.cc

[song bruce zhang (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3233

to look at the new patch set (#7).

Change subject:  fix compile error when compiling column_predicate-test.cc
..

fix compile error when compiling column_predicate-test.cc

 In env : boost 1.57, centos 6.5, it will fail when compiling
 column_predicate-test.cc.
 Specific error messages:
 "gtest-printers.h:245: undefined reference to `std::basic_ostream& boost::operator<< >(std::basic_ostream&, boost::optional const&)`"

 Adding optional_io.hpp into column_predicate.h get another compile error:
 "operator<<: cannot bind lvalue to 'std::basic_ostream&&'"
 write a boost:operator<< in column_predicate.c , compile succeed.

Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
---
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
2 files changed, 25 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3233/7
-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang 

[kudu-CR] fix compile error when compiling column_predicate-test.cc

[song bruce zhang (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3233

to look at the new patch set (#6).

Change subject:  fix compile error when compiling column_predicate-test.cc
..

fix compile error when compiling column_predicate-test.cc

 In env : boost 1.57, centos 6.5, it will fail when compiling
 column_predicate-test.cc.
 Specific error messages:
 "gtest-printers.h:245: undefined reference to `std::basic_ostream& boost::operator<< >(std::basic_ostream&, boost::optional const&)`"

 Adding optional_io.hpp into column_predicate.h get another compile error:
 "operator<<: cannot bind lvalue to 'std::basic_ostream&&'"
 write a boost:operator<< in column_predicate.c , compile succeed.

Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
---
M src/kudu/common/column_predicate.cc
M src/kudu/common/column_predicate.h
2 files changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/33/3233/6
-- 
To view, visit http://gerrit.cloudera.org:8080/3233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6f9a9634eeccd86616be80b004ecce596155bb57
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang