[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread zhen.zhang (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3013 to look at the new patch set (#9). Change subject: KUDU-1444. Get resource metrics of a scan. ..

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 8: > What should I do to help rebase? Try rebasing locally with your patch, see if you can solve

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread zhen.zhang (Code Review)
zhen.zhang has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 8: What should I do to help rebase? -- To view, visit http://gerrit.cloudera.org:8080/3013 To

[kudu-CR] Add unique id generation to the client

2016-05-30 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add unique id generation to the client .. Add unique id generation to the client This adds unique id generation to the client, which takes the

[kudu-CR] Add a RpcContext::RespondFailure() method

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 6: (2 comments) wonder whether it would be a clearer API to instead have a flag like

[kudu-CR] WIP: Integrate the request tracker with the client

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Integrate the request tracker with the client .. Patch Set 7: (2 comments) would be nice to have some kind of test for this at the rpc layer (against a

[kudu-CR] Add unique id generation to the client

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add unique id generation to the client .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3077 To unsubscribe, visit

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark .. Patch Set 3: (1 comment)

[kudu-CR] Allow to set RequestId in the RPC RequestHeader

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to set RequestId in the RPC RequestHeader .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3179/3/src/kudu/rpc/rpc_controller.h File

[kudu-CR] Specify guaranteed semantics of GetTableLocations RPC

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Specify guaranteed semantics of GetTableLocations RPC .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3240/1/src/kudu/master/catalog_manager.cc

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3013 To unsubscribe, visit

[kudu-CR] KUDU-1444. Get resource metrics of a scan.

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1444. Get resource metrics of a scan. .. Patch Set 8: Looks like this needs a manual rebase -- To view, visit http://gerrit.cloudera.org:8080/3013 To

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-05-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc