[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3234/1/src/kudu/consensus/log.cc

[kudu-CR] consensus: Crash if we fail to append to the WAL

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: Crash if we fail to append to the WAL .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3406/3/src/kudu/util/status_callback.cc File

[kudu-CR] catalog manager: fix a locking error

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: catalog_manager: fix a locking error .. catalog_manager: fix a locking error This lock acquisition took the wrong lock, which meant it didn't add any

[kudu-CR] catalog manager: fix a locking error

2016-06-21 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3425 to look at the new patch set (#2). Change subject: catalog_manager: fix a locking error .. catalog_manager: fix a

[kudu-CR] catalog manager: fix a locking error

2016-06-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: catalog_manager: fix a locking error .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1921/ -- To view, visit

[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: catalog_manager: fix a locking brain fart .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3425/1//COMMIT_MSG Commit Message: Line 7:

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3424 to look at the new patch set (#4). Change subject: Add additional documentation for bad installation .. Add

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3234/2/src/kudu/consensus/log.cc

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3424 to look at the new patch set (#3). Change subject: Add additional documentation for bad installation .. Add

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add additional documentation for bad installation .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/1919/ -- To view, visit

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: log: Mark allocation finished even if allocation had an error .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/1918/ -- To view, visit

[kudu-CR] log: Mark allocation finished even if allocation had an error

2016-06-21 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3234 to look at the new patch set (#3). Change subject: log: Mark allocation finished even if allocation had an error

[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3425 to review the following change. Change subject: catalog_manager: fix a locking brain fart ..

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add additional documentation for bad installation .. Patch Set 2: Since you're modifying an asciidoc file, could you generate rendered output too? The easiest way

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add additional documentation for bad installation .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1915/ -- To view, visit

[kudu-CR] Add additional documentation for bad installation

2016-06-21 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3424 to look at the new patch set (#2). Change subject: Add additional documentation for bad installation .. Add

[kudu-CR] Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project. ..

[kudu-CR] Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project.

2016-06-21 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Added more to the documentation for botched installation. Users should uninstall the dependencies and install them again after cleaning the project. .. Patch

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Mark the Response accessors in transactions/transaction's state const .. Mark the Response accessors in transactions/transaction's state const

[kudu-CR] Mark the Response accessors in transactions/transaction's state const

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Mark the Response accessors in transactions/transaction's state const .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3419 To

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: was looking into updating gmock and it seems like it has moved to a

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: Verified+1 unrelated failure on

[kudu-CR](gh-pages) Add weekly update for 06/21

2016-06-21 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add weekly update for 06/21 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3415 To unsubscribe, visit

[kudu-CR](gh-pages) Add weekly update for 06/21

2016-06-21 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add weekly update for 06/21 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3415 To unsubscribe, visit