[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 2: Code-Review+2 thanks for adding the additional info -- To view, visit

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3517/2//COMMIT_MSG

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2079/ -- To view, visit

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3517 to look at the new patch set (#2). Change subject: tablet: change default bloom filter FP rate to 0.01%

[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 4: (7 comments)

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 5: Verified+1 There was a build failure in the RELEASE build: 01:36:24 Linking CXX

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: locks: switch from boost::shared_mutex to new read-write mutex .. Patch Set 5: Verified+1 Overriding Jenkins, flaky ksck timeout test. -- To view, visit

[kudu-CR] [java-client] refactor AsyncKuduSession

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java-client] refactor AsyncKuduSession .. Patch Set 3: (16 comments) Achievement unlocked: asynchronous programming wizard.

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3517/1/docs/release_notes.adoc File

[kudu-CR] Persistent cache support for NVM

2016-06-27 Thread Sarah Jelinek (Code Review)
Sarah Jelinek has posted comments on this change. Change subject: Persistent cache support for NVM .. Patch Set 16: (1 comment) Pushed all code review changes.

[kudu-CR] Persistent cache support for NVM

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Persistent cache support for NVM .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2078/ -- To view, visit

[kudu-CR] Persistent cache support for NVM

2016-06-27 Thread Sarah Jelinek (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2593 to look at the new patch set (#16). Change subject: Persistent cache support for NVM .. Persistent cache support

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3517 To unsubscribe,

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: tablet: change default bloom filter FP rate to 0.01% .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2077/ -- To view, visit

[kudu-CR] tablet: change default bloom filter FP rate to 0.01%

2016-06-27 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3517 to review the following change. Change subject: tablet: change default bloom filter FP rate to 0.01% ..

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 5: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2075/ -- To view, visit

[kudu-CR] locks: switch from boost::shared lock to kudu::shared lock

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: switch from boost::shared_lock to kudu::shared_lock .. Patch Set 5: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2073/ -- To view,

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 5: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2076/ -- To view,

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 4: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2072/ -- To view, visit

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 4: (1 comment) > (1 comment) > > LGTM with some concern regarding error detection if something goes > wrong. >

[kudu-CR] locks: switch from boost::shared lock to kudu::shared lock

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: switch from boost::shared_lock to kudu::shared_lock .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2070/ -- To view, visit

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2068/ -- To view, visit

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2067/ -- To view, visit

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2071/ -- To view, visit

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: switch from boost::shared_mutex to new read-write mutex .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2069/ -- To view, visit

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3496 to look at the new patch set (#5). Change subject: locks: add new read-write mutex .. locks: add

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. KUDU-1496. NoLeaderMasterFoundException are mishandled This is a regression from

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: Verified+1 Forcing +1 due to current messed up workspace. -- To view, visit

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3516 To unsubscribe, visit

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2066/ -- To view, visit

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: switch from boost::shared_mutex to new read-write mutex .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2064/ -- To view, visit

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2063/ -- To view, visit

[kudu-CR] locks: switch from boost::shared lock to kudu::shared lock

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: switch from boost::shared_lock to kudu::shared_lock .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2065/ -- To view, visit

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2062/ -- To view, visit

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3496 to look at the new patch set (#4). Change subject: locks: add new read-write mutex .. locks: add

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3500 To unsubscribe, visit

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: (1 comment) > Oops. > > Outside of multi-master, this only manifests when the

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: Code-Review+2 Oops. Outside of multi-master, this only manifests when the sole master is

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3516 Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. KUDU-1496. NoLeaderMasterFoundException are mishandled

[kudu-CR] KUDU-1496. NoLeaderMasterFoundException are mishandled

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1496. NoLeaderMasterFoundException are mishandled .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2061/ -- To view, visit

[kudu-CR] Add a ToString() method to Proxy

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 1: would be nice to add a new assertion to one of the RPC layer tests which calls this -- To view, visit

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add 6/27 weekly update .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3515 To unsubscribe, visit

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Add 6/27 weekly update .. Add 6/27 weekly update Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2 Reviewed-on: http://gerrit.cloudera.org:8080/3515

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 6/27 weekly update .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3515 To unsubscribe, visit

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: Add 6/27 weekly update .. Add 6/27 weekly update Change-Id: I6ce4bf6e02a5481bf3e032d3345d7afc93c244a2 --- A _posts/2016-06-27-weekly-update.md 1 file changed, 91

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add 6/27 weekly update .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3515/1/_posts/2016-06-27-weekly-update.md File

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3500 to look at the new patch set (#2). Change subject: thirdparty: add boost and switch to header-only build ..

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: switch from boost::shared_mutex to new read-write mutex .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2058/ -- To view, visit

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Adar Dembo (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3497 to look at the new patch set (#3). Change subject: locks: change kudu::shared_lock constructor to pass by ref

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2057/ -- To view, visit

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2060/ -- To view, visit

[kudu-CR](gh-pages) Add 6/27 weekly update

2016-06-27 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3515 to review the following change. Change subject: Add 6/27 weekly update .. Add 6/27 weekly update Change-Id:

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: yea, ASAN does insert poisoning between variables on the stack:

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3511 To

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: A java test failed due to https://issues.apache.org/jira/browse/KUDU-1496

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: > Also not sure of the purpose of the extra red zones (ASAN > would already insert those

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: The boost implementation already has ASSERTs for accessing it while not initialized, so

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: > I would like some careful eyes on this before we merge it, as the > move semantics

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: > Well, the call sites are going to stay the same, but we're taking > on a few hundred

[kudu-CR] Allow to force-override color diagnostics

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow to force-override color diagnostics .. Patch Set 1: Code-Review+2 Sounds like there's a reasonable use case for it. -- To view, visit

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: > This is meant to completely replace our usage of boost::optional so it should > be net

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc File

[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

2016-06-27 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3514 to review the following change. Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

[kudu-CR] ts recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: ts_recovery-itest: fix flakiness in TestRestartWithPendingCommitFromFailedOp .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2055/ -- To

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3512/1/src/kudu/util/optional.h File

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: > I don't see the purpose of taking on this extra code. Code's a > liability, not an

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: (3 comments) I only skimmed this; I think a real review requires a level of C++ knowledge

[kudu-CR] Migrate from boost::optional to kudu::optional

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Migrate from boost::optional to kudu::optional .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3513/1/src/kudu/tablet/memrowset.cc File

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2054/ -- To

[kudu-CR] Allow to force-override color diagnostics

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Allow to force-override color diagnostics .. Patch Set 1: I use something like this locally -- when I run 'ninja', it sometimes re-runs cmake for me, but the

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: Code-Review-1 I don't see the purpose of taking on this extra code. Code's a liability,

[kudu-CR] Allow to force-override color diagnostics

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Allow to force-override color diagnostics .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3509/1/CMakeLists.txt File CMakeLists.txt: Line 230:

[kudu-CR] Update docs on how to run gcovr

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Update docs on how to run gcovr .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc File README.adoc: Line 241: $ mkdir cov_html

[kudu-CR] Allow to force-override color diagnostics

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Allow to force-override color diagnostics .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3509/1/CMakeLists.txt File CMakeLists.txt: Line 230:

[kudu-CR] Migrate from boost::optional to kudu::optional

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Migrate from boost::optional to kudu::optional .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2053/ -- To view, visit

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3500/1/docs/contributing.adoc File

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Implement kudu::optional replacement for boost::optional .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2052/ -- To view, visit

[kudu-CR] Implement kudu::optional replacement for boost::optional

2016-06-27 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3512 to review the following change. Change subject: Implement kudu::optional replacement for boost::optional .. Implement

[kudu-CR] Migrate from boost::optional to kudu::optional

2016-06-27 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3513 to review the following change. Change subject: Migrate from boost::optional to kudu::optional .. Migrate from

[kudu-CR] Update docs on how to run gcovr

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Update docs on how to run gcovr .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3508/1/README.adoc File README.adoc: Line 241: $ mkdir cov_html

[kudu-CR] thirdparty: add boost and switch to header-only build

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: thirdparty: add boost and switch to header-only build .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3500/1//COMMIT_MSG Commit Message: Line

[kudu-CR] locks: stop using errno around base::NumCPUs and base::MaxCPUIndex

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: locks: stop using errno around base::NumCPUs and base::MaxCPUIndex .. locks: stop using errno around base::NumCPUs and base::MaxCPUIndex It's not clear

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Todd Lipcon (Code Review)
Hello Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3511 to review the following change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File src/kudu/util/rw_mutex.cc:

[kudu-CR] Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2051/ -- To view,

[kudu-CR](gh-pages) kudu flume sink blog post

2016-06-27 Thread Ara Ebrahimi (Code Review)
Ara Ebrahimi has uploaded a new change for review. http://gerrit.cloudera.org:8080/3510 Change subject: kudu flume sink blog post .. kudu flume sink blog post Change-Id: I810146ab24c88bc6cc562d81746b9bf5303396ed --- A

[kudu-CR] locks: add new read-write mutex

2016-06-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: locks: add new read-write mutex .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3496/2/src/kudu/util/rw_mutex.cc File

[kudu-CR] Integrate the result tracker with writes

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 7: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2050/ -- To view, visit

[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 6: -Verified Build Started

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2047/ -- To view, visit

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#16). Change subject: Integrate the ResultTracker into the rpc subsystem ..

[kudu-CR] Integrate the ResultTracker into the rpc subsystem

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2049/ -- To view, visit

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings in raft_consensus-test.cc In

[kudu-CR] Allow to force-override color diagnostics

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Allow to force-override color diagnostics .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2046/ -- To view, visit

[kudu-CR] Allow to force-override color diagnostics

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3509 Change subject: Allow to force-override color diagnostics .. Allow to force-override color diagnostics Change-Id:

[kudu-CR] Update docs on how to run gcovr

2016-06-27 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/3508 Change subject: Update docs on how to run gcovr .. Update docs on how to run gcovr Change-Id: I494136e20452b76572d753b54fc7a095aa54a69b

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3289 To

[kudu-CR] locks: change kudu::shared lock constructor to pass by ref

2016-06-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: locks: change kudu::shared_lock constructor to pass by ref .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3497/2/src/kudu/util/locks.h File

[kudu-CR] Integrate the request tracker with the client

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 13: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/2044/ -- To view, visit

  1   2   >