[kudu-CR] WIP
David Ribeiro Alves has abandoned this change. Change subject: WIP .. Abandoned pulled this into other patches -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
David Ribeiro Alves has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/3192/11/src/kudu/rpc/protoc-gen-krpc.cc File src/kudu/rpc/protoc-gen-krpc.cc: Line 467: "mi->result_tracker.reset($result_tracker$);\n" > pondered this a bit more, seems like, for now it won't make a difference ei actually done this -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: Yes
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2194/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#17). Change subject: Add integration tests for replay cache with writes .. Add integration tests for replay cache with writes This adds a couple of new integration tests for replay cache with writes. Both tests start multiple threads writing, independently, to tablet servers simulaneously. The tests leverage the fact that followers are also able to answer requests, once they are cached, and stores all responses, which are compared at the end of the test. Some of the requests (1/3) are "empty" writes, so that we stress the serialization point in transaction_driver.cc without relying on row lock serialization. This adds two different tests, one that stresses a lot of elections and one that crashes nodes. This is inline with other tests we already had in raft_consensus-itest. I looped this about 100 times, without failures. Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 238 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3519/17 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2193/ -- To view, visit http://gerrit.cloudera.org:8080/3570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Kudu Jenkins has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2188/ -- To view, visit http://gerrit.cloudera.org:8080/3505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2190/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2187/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2189/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#14). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes this patch doesn't include additional tests, which will be pushed later, ad-hoc. The reasoning being that we'll benefit from more coverage in the meanwhile. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 25 files changed, 397 insertions(+), 34 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/14 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a way to dump ResultTracker state
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2192/ -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a fault injection point after the leader sends a request
Kudu Jenkins has posted comments on this change. Change subject: Add a fault injection point _after_ the leader sends a request .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2191/ -- To view, visit http://gerrit.cloudera.org:8080/3568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504d74ac3ab3a8cb120d4e5ecee308d9846f3829 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3505 to look at the new patch set (#9). Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Add a test for the integration of RequestTracker with the client and ResultTracker with the server This adds a test for the integration of the RequestTracker in the client and the ResultTracker in the server. Specifically it tests that RetriableRpc works in combination with replayed results from the ResultTracker and that multiple simultaneous (similar) RPCs from the client are not executed more than once. Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b --- M src/kudu/rpc/CMakeLists.txt A src/kudu/rpc/rpc-stress-test.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rtest.proto 4 files changed, 367 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3505/9 -- To view, visit http://gerrit.cloudera.org:8080/3505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 19: Build Started http://104.196.14.100/job/kudu-gerrit/2186/ -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3192 to look at the new patch set (#19). Change subject: Integrate the ResultTracker into the rpc subsystem .. Integrate the ResultTracker into the rpc subsystem This integrates the ResultTracker into the rpc subsystem by allowing to specify a new method option when defining rpc service methods. When this method option is specificed _and_ the call's rpc header has a RequestIdPB the results for the call will be tracked and the call may have exactly once semantics. This allows to have the simplest form of exactly once semantics for single server calls. Of course limitations apply, like response persistence across restarts is not supported, neither is propagating/rebuilding responses to/on replicas for replicated calls. If support for this is needed it will have to be done ad-hoc, case by case. A follow up patch tests this in integration with the client. Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 --- M src/kudu/master/master.cc M src/kudu/master/master_service.cc M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/inbound_call.cc M src/kudu/rpc/protoc-gen-krpc.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/rpc_header.proto M src/kudu/rpc/service_if.cc M src/kudu/rpc/service_if.h M src/kudu/server/generic_service.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h 19 files changed, 185 insertions(+), 58 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/3192/19 -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 19 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] WIP
Kudu Jenkins has posted comments on this change. Change subject: WIP .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2185/ -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3572 to look at the new patch set (#5). Change subject: WIP .. WIP Not for review. Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 --- M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/master/master.cc M src/kudu/master/master_service.cc M src/kudu/rpc/protoc-gen-krpc.cc M src/kudu/rpc/rpc-test-base.h M src/kudu/server/generic_service.cc M src/kudu/server/server_base.cc M src/kudu/server/server_base.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/remote_bootstrap_service.h M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tablet_service.h M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h 19 files changed, 72 insertions(+), 78 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3572/5 -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. KUDU-1309: [java client] support tables with non-covering partition-key ranges This commit adds support for accessing and creating tables with non-covering range partitions to the Java client. The only public interface introduced is the CreateTableOptions.addRangeBound method. Otherwise, all the changes are necessary for reading or writing to tables with range partition gaps. Right now if a client attempts to write to a non-covered range, a NotFound status is returned, which matches the C++ client. JD pointed out that this makes it impossible for applications to distinguish between failed updates because the row doesn't exist, and failed updates because the partition range doesn't exist. I plan to fix this by introducing a new status code and fixing both clients in a follow up commit. Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Reviewed-on: http://gerrit.cloudera.org:8080/3388 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo Reviewed-by: Jean-Daniel Cryans --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/BatchResponse.java M java/kudu-client/src/main/java/org/kududb/client/Bytes.java M java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/kududb/client/CreateTableRequest.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpcResponse.java A java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java A java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java M java/kudu-client/src/main/java/org/kududb/client/OperationResponse.java M java/kudu-client/src/main/java/org/kududb/client/Partition.java M java/kudu-client/src/main/java/org/kududb/client/RowError.java M java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/TestFlexiblePartitioning.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java 22 files changed, 839 insertions(+), 138 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Adar Dembo has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Dan Burkert has posted comments on this change.
Change subject: KUDU-1309: [java client] support tables with non-covering
partition-key ranges
..
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3388/4/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java:
Line 327: operation.callback(response);
> Dan, I think you missed this discussion. Sounds like there's a missing chec
Done
http://gerrit.cloudera.org:8080/#/c/3388/2/java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java
File java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java:
Line 84: @Override
> I think you missed this.
fixed.
Line 89: for (Map.Entry range :
nonCoveredRanges.entrySet()) {
> Think you missed this.
yah I'm not crazy about Joiner unless there is already a List.
--
To view, visit http://gerrit.cloudera.org:8080/3388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2184/ -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3388 to look at the new patch set (#8). Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. KUDU-1309: [java client] support tables with non-covering partition-key ranges This commit adds support for accessing and creating tables with non-covering range partitions to the Java client. The only public interface introduced is the CreateTableOptions.addRangeBound method. Otherwise, all the changes are necessary for reading or writing to tables with range partition gaps. Right now if a client attempts to write to a non-covered range, a NotFound status is returned, which matches the C++ client. JD pointed out that this makes it impossible for applications to distinguish between failed updates because the row doesn't exist, and failed updates because the partition range doesn't exist. I plan to fix this by introducing a new status code and fixing both clients in a follow up commit. Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/BatchResponse.java M java/kudu-client/src/main/java/org/kududb/client/Bytes.java M java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/kududb/client/CreateTableRequest.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpcResponse.java A java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java A java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java M java/kudu-client/src/main/java/org/kududb/client/OperationResponse.java M java/kudu-client/src/main/java/org/kududb/client/Partition.java M java/kudu-client/src/main/java/org/kududb/client/RowError.java M java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/TestFlexiblePartitioning.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java 22 files changed, 839 insertions(+), 138 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3388/8 -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP
Kudu Jenkins has posted comments on this change. Change subject: WIP .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2183/ -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3572 to look at the new patch set (#4). Change subject: WIP .. WIP Not for review. Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3572/4 -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Adar Dembo has posted comments on this change.
Change subject: KUDU-1309: [java client] support tables with non-covering
partition-key ranges
..
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/3388/4/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java:
Line 327: operation.callback(response);
> It will do it right here, since it's the operation's callback were invoking
Dan, I think you missed this discussion. Sounds like there's a missing check on
AUTO_FLUSH_BACKGROUND, and perhaps there should be a comment explaining the
lack of importance in order between invoking the user's callback and updating
the error collector.
http://gerrit.cloudera.org:8080/#/c/3388/2/java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java
File java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java:
Line 84: @Override
> Really? I thought ConcurrentSkipListMap defines an iteration order in the f
I think you missed this.
Line 89: for (Map.Entry range :
nonCoveredRanges.entrySet()) {
> No love for Joiner? Bear in mind size() is more expensive on a ConcurrentSk
Think you missed this.
--
To view, visit http://gerrit.cloudera.org:8080/3388
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert
Gerrit-Reviewer: Adar Dembo
Gerrit-Reviewer: Dan Burkert
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] WIP
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3572 to look at the new patch set (#3). Change subject: WIP .. WIP Not for review. Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3572/3 -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP
Kudu Jenkins has posted comments on this change. Change subject: WIP .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2182/ -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2181/ -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] KUDU-1309: [java client] support tables with non-covering partition-key ranges
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3388 to look at the new patch set (#7). Change subject: KUDU-1309: [java client] support tables with non-covering partition-key ranges .. KUDU-1309: [java client] support tables with non-covering partition-key ranges This commit adds support for accessing and creating tables with non-covering range partitions to the Java client. The only public interface introduced is the CreateTableOptions.addRangeBound method. Otherwise, all the changes are necessary for reading or writing to tables with range partition gaps. Right now if a client attempts to write to a non-covered range, a NotFound status is returned, which matches the C++ client. JD pointed out that this makes it impossible for applications to distinguish between failed updates because the row doesn't exist, and failed updates because the partition range doesn't exist. I plan to fix this by introducing a new status code and fixing both clients in a follow up commit. Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/BatchResponse.java M java/kudu-client/src/main/java/org/kududb/client/Bytes.java M java/kudu-client/src/main/java/org/kududb/client/CreateTableOptions.java M java/kudu-client/src/main/java/org/kududb/client/CreateTableRequest.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpcResponse.java A java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeCache.java A java/kudu-client/src/main/java/org/kududb/client/NonCoveredRangeException.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java M java/kudu-client/src/main/java/org/kududb/client/OperationResponse.java M java/kudu-client/src/main/java/org/kududb/client/Partition.java M java/kudu-client/src/main/java/org/kududb/client/RowError.java M java/kudu-client/src/main/java/org/kududb/client/RowResultIterator.java M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/TestFlexiblePartitioning.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduClient.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/TestKuduTable.java 22 files changed, 830 insertions(+), 138 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/3388/7 -- To view, visit http://gerrit.cloudera.org:8080/3388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id65a1f8a95bb16fc0360a17021a391afd3c9d03f Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP
Kudu Jenkins has posted comments on this change. Change subject: WIP .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2180/ -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3572 to look at the new patch set (#2). Change subject: WIP .. WIP Not for review. Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 6 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3572/2 -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] WIP
Kudu Jenkins has posted comments on this change. Change subject: WIP .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2179/ -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] WIP
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3572 Change subject: WIP .. WIP Not for review. Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 --- M src/kudu/tablet/transactions/transaction_driver.cc 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3572/1 -- To view, visit http://gerrit.cloudera.org:8080/3572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I717ef1e3f079d868f1fb80b37613203e39540f67 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] Add integration tests for replay cache with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#16). Change subject: Add integration tests for replay cache with writes .. Add integration tests for replay cache with writes This adds a couple of new integration tests for replay cache with writes. Both tests start multiple threads writing, independently, to tablet servers simulaneously. The tests leverage the fact that followers are also able to answer requests, once they are cached, and stores all responses, which are compared at the end of the test. Some of the requests (1/3) are "empty" writes, so that we stress the serialization point in transaction_driver.cc without relying on row lock serialization. This adds two different tests, one that stresses a lot of elections and one that crashes nodes. This is inline with other tests we already had in raft_consensus-itest. I looped this about 100 times, without failures. Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 237 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3519/16 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2178/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2177/ -- To view, visit http://gerrit.cloudera.org:8080/3570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#13). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes this patch doesn't include additional tests, which will be pushed later, ad-hoc. The reasoning being that we'll benefit from more coverage in the meanwhile. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/service_if.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 29 files changed, 439 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/13 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2176/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] [java-client] fix NPE when batch flush fails
Dan Burkert has submitted this change and it was merged. Change subject: [java-client] fix NPE when batch flush fails .. [java-client] fix NPE when batch flush fails Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 Reviewed-on: http://gerrit.cloudera.org:8080/3564 Reviewed-by: Adar Dembo Tested-by: Kudu Jenkins --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java 4 files changed, 66 insertions(+), 3 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java-client] fix NPE when batch flush fails
Adar Dembo has posted comments on this change. Change subject: [java-client] fix NPE when batch flush fails .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] fix NPE when batch flush fails
Dan Burkert has posted comments on this change. Change subject: [java-client] fix NPE when batch flush fails .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3564/1/java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java File java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java: Line 158: session.setTimeoutMillis(100); > Seems rather high; a fast cluster could satisfy this, no? Why not 1? Or 0? no reason, it just needed to be shorter than the default of many seconds for practical purposes. Set to 1. -- To view, visit http://gerrit.cloudera.org:8080/3564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] [java-client] fix NPE when batch flush fails
Kudu Jenkins has posted comments on this change. Change subject: [java-client] fix NPE when batch flush fails .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2175/ -- To view, visit http://gerrit.cloudera.org:8080/3564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] [java-client] fix NPE when batch flush fails
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3564 to look at the new patch set (#2). Change subject: [java-client] fix NPE when batch flush fails .. [java-client] fix NPE when batch flush fails Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduSession.java M java/kudu-client/src/test/java/org/kududb/client/BaseKuduTest.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java M java/kudu-client/src/test/java/org/kududb/client/TestAsyncKuduSession.java 4 files changed, 66 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/64/3564/2 -- To view, visit http://gerrit.cloudera.org:8080/3564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icaf8ab20a0d8142ea38a17a648839e935aaef741 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2174/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2173/ -- To view, visit http://gerrit.cloudera.org:8080/3570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2172/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#12). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes this patch doesn't include additional tests, which will be pushed later, ad-hoc. The reasoning being that we'll benefit from more coverage in the meanwhile. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/service_if.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 29 files changed, 439 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/12 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2171/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 14 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2170/ -- To view, visit http://gerrit.cloudera.org:8080/3570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2169/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#11). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes this patch doesn't include additional tests, which will be pushed later, ad-hoc. The reasoning being that we'll benefit from more coverage in the meanwhile. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/service_if.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 29 files changed, 439 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/11 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a test for the integration of RequestTracker with the client and ResultTracker with the server
Kudu Jenkins has posted comments on this change. Change subject: Add a test for the integration of RequestTracker with the client and ResultTracker with the server .. Patch Set 8: Build Started http://104.196.14.100/job/kudu-gerrit/2157/ -- To view, visit http://gerrit.cloudera.org:8080/3505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic193dd5a547fe2a107a2ab1625f93fa0c19cc61b Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a RpcContext::RespondFailure() method
Kudu Jenkins has posted comments on this change. Change subject: Add a RpcContext::RespondFailure() method .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2161/ -- To view, visit http://gerrit.cloudera.org:8080/3191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1387ba0f837046a8056e77f73a3982f06c73a2 Gerrit-PatchSet: 15 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a ResultTracker class that will track server side results
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3190 to look at the new patch set (#17). Change subject: Add a ResultTracker class that will track server side results .. Add a ResultTracker class that will track server side results This adds the initial version of the ResultTracker class that will be responsible for tracking responses when we want exactly once call semantics. While this is minimally working, i.e it's able to track responses and can be used for exactly once semantics, it's not complete. Future patches will address the missing functionality. Still missing are: - Time based client state cleaning. - Watermark based per client state cleaning. I initially had a unit test for this class, but it relied on templating out the RpcContext (since it's not easy to build one for a unit test and it's not clear what it would do) which became problematic as the class grew. So I decided to add a new rpc-stress-tess that will test this class within the rpc framework. I feel it's easier to do it that way and that, since the client is not being used, the test can still be very straight forward. This test is in a followup patch as it can only run after the integration with the rest of the rpc subsystem. Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 --- M src/kudu/rpc/CMakeLists.txt A src/kudu/rpc/result_tracker.cc A src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.h 4 files changed, 592 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/3190/17 -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()
Kudu Jenkins has posted comments on this change. Change subject: Make RequestTracker not return Status on FirstIncomplete() .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2156/ -- To view, visit http://gerrit.cloudera.org:8080/3504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a fault injection point after the leader sends a request
Kudu Jenkins has posted comments on this change. Change subject: Add a fault injection point _after_ the leader sends a request .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2166/ -- To view, visit http://gerrit.cloudera.org:8080/3568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I504d74ac3ab3a8cb120d4e5ecee308d9846f3829 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
Kudu Jenkins has posted comments on this change. Change subject: Add a way to include request ids in log-dump .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2168/ -- To view, visit http://gerrit.cloudera.org:8080/3570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md
Kudu Jenkins has posted comments on this change. Change subject: Add information about Exactly Once RPC semantics to rpc.md .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2163/ -- To view, visit http://gerrit.cloudera.org:8080/3503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a ToString() method to Proxy
Kudu Jenkins has posted comments on this change. Change subject: Add a ToString() method to Proxy .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2165/ -- To view, visit http://gerrit.cloudera.org:8080/3502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e158db09e6e3c188b2725424681187a4b8c72e Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3519 to look at the new patch set (#13). Change subject: Add integration tests for replay cache with writes .. Add integration tests for replay cache with writes This adds a couple of new integration tests for replay cache with writes. Both tests start multiple threads writing, independently, to tablet servers simulaneously. The tests leverage the fact that followers are also able to answer requests, once they are cached, and stores all responses, which are compared at the end of the test. Some of the requests (1/3) are "empty" writes, so that we stress the serialization point in transaction_driver.cc without relying on row lock serialization. This adds two different tests, one that stresses a lot of elections and one that crashes nodes. This is inline with other tests we already had in raft_consensus-itest. I looped this about 100 times, without failures. Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f --- M src/kudu/integration-tests/raft_consensus-itest.cc 1 file changed, 237 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/3519/13 -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Integrate the result tracker with writes
Kudu Jenkins has posted comments on this change. Change subject: Integrate the result tracker with writes .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2159/ -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the result tracker with writes
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3449 to look at the new patch set (#10). Change subject: Integrate the result tracker with writes .. Integrate the result tracker with writes This patch integrates the result tracker with write transactions, including: - Support for caching responses on tablet bootstrap. - Support for caching responses for follower transactions. - Handling of races between client originated and (previous?) leader originated transactions. - An explanation of the interaction between the result tracker and the transaction driver in transaction_driver.h. For integration tests, this patch removes the check that allowed Status::AlreadyPresent() that we added as we didn't have support for exactly once semantics. Without this check, in slow mode, some tests like raft_consensus-itest would fail 100% of the time, due to rows being inserted multiple times. Because we'd have 100% failure rate without replay cache for writes this patch doesn't include additional tests, which will be pushed later, ad-hoc. The reasoning being that we'll benefit from more coverage in the meanwhile. Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 --- M src/kudu/client/batcher.cc M src/kudu/consensus/consensus.proto M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/test_workload.h M src/kudu/master/sys_catalog.cc M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h M src/kudu/rpc/rpc_context.cc M src/kudu/rpc/rpc_context.h M src/kudu/rpc/service_if.cc M src/kudu/tablet/tablet_bootstrap-test.cc M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_bootstrap.h M src/kudu/tablet/tablet_peer-test.cc M src/kudu/tablet/tablet_peer.cc M src/kudu/tablet/tablet_peer.h M src/kudu/tablet/transactions/transaction.h M src/kudu/tablet/transactions/transaction_driver.cc M src/kudu/tablet/transactions/transaction_driver.h M src/kudu/tablet/transactions/write_transaction.cc M src/kudu/tablet/transactions/write_transaction.h M src/kudu/tools/insert-generated-rows.cc M src/kudu/tserver/CMakeLists.txt M src/kudu/tserver/remote_bootstrap_session-test.cc M src/kudu/tserver/tablet_server.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/ts_tablet_manager.cc M src/kudu/tserver/ts_tablet_manager.h M src/kudu/tserver/tserver_service.proto 29 files changed, 433 insertions(+), 38 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/49/3449/10 -- To view, visit http://gerrit.cloudera.org:8080/3449 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I1fa2f8db33653960f4749237b8993baba0929893 Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add a way to dump ResultTracker state
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3569 Change subject: Add a way to dump ResultTracker state .. Add a way to dump ResultTracker state This adds a way to dump result tracker state and makes sure we use it when FATAling out on CHECK failures. Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 --- M src/kudu/rpc/result_tracker.cc M src/kudu/rpc/result_tracker.h 2 files changed, 60 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/3569/1 -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] Add a way to dump ResultTracker state
Kudu Jenkins has posted comments on this change. Change subject: Add a way to dump ResultTracker state .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2167/ -- To view, visit http://gerrit.cloudera.org:8080/3569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I418da53b52aba5f8358b08709ffe65ece132aeb1 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] Integrate the request tracker with the client
Kudu Jenkins has posted comments on this change. Change subject: Integrate the request tracker with the client .. Patch Set 16: Build Started http://104.196.14.100/job/kudu-gerrit/2155/ -- To view, visit http://gerrit.cloudera.org:8080/3080 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94207c294452fcbdb3a7901fdb702674d47553ee Gerrit-PatchSet: 16 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Integrate the ResultTracker into the rpc subsystem
Kudu Jenkins has posted comments on this change. Change subject: Integrate the ResultTracker into the rpc subsystem .. Patch Set 18: Build Started http://104.196.14.100/job/kudu-gerrit/2160/ -- To view, visit http://gerrit.cloudera.org:8080/3192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d624810350feceefe244e0319e22cac241bf0d6 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Disable exactly once semantics by default and add a flag to enable it for tests
Kudu Jenkins has posted comments on this change. Change subject: Disable exactly once semantics by default and add a flag to enable it for tests .. Patch Set 7: Build Started http://104.196.14.100/job/kudu-gerrit/2158/ -- To view, visit http://gerrit.cloudera.org:8080/3506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77096be608afb31194f62f04a946bd3f42537a35 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add integration tests for replay cache with writes
Kudu Jenkins has posted comments on this change. Change subject: Add integration tests for replay cache with writes .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2164/ -- To view, visit http://gerrit.cloudera.org:8080/3519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35722eb1c83f97e886cfe9d6b03ed95bcd62429f Gerrit-PatchSet: 13 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add a way to include request ids in log-dump
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3570 Change subject: Add a way to include request ids in log-dump .. Add a way to include request ids in log-dump This adds a way to output the request ids, if they exist, in log-dump.cc. This is helpful when debugging as it allows to see which writes the request ids get associated with. Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a --- M src/kudu/consensus/log-dump.cc 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/70/3570/1 -- To view, visit http://gerrit.cloudera.org:8080/3570 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0ec824461d9753ab3726d4a06156e32d5515a12a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] Add a fault injection point after the leader sends a request
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3568 Change subject: Add a fault injection point _after_ the leader sends a request .. Add a fault injection point _after_ the leader sends a request This adds a new fault injection point right after the leader sends a request. We currently have one right _before_ the leader sends a request, but having one for after the request is sent encourages stressing the path where a newly elected leader as both incoming client request and ongoing replica transactions, which can possibly race with each other if they correspond to the same write. Change-Id: I504d74ac3ab3a8cb120d4e5ecee308d9846f3829 --- M src/kudu/consensus/consensus_peers.cc 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/3568/1 -- To view, visit http://gerrit.cloudera.org:8080/3568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I504d74ac3ab3a8cb120d4e5ecee308d9846f3829 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves
[kudu-CR] Add a ResultTracker class that will track server side results
Kudu Jenkins has posted comments on this change. Change subject: Add a ResultTracker class that will track server side results .. Patch Set 17: Build Started http://104.196.14.100/job/kudu-gerrit/2162/ -- To view, visit http://gerrit.cloudera.org:8080/3190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6718951a9998a6c9b0db35e8f09ff8304591e8b1 Gerrit-PatchSet: 17 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
