[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 15: (7 comments) http://gerrit.cloudera.org:8080/#/c/3627/15/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/resu

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics .. Patch Set 5: We should make sure not to forget about this one before calling all the replay cache work "done"

[kudu-CR] rw mutex: prevent recursive use

2016-07-15 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#15). Change subject: Memory tracking for result tracker .. Memory tracking for resul

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 15: Build Started http://104.196.14.100/job/kudu-gerrit/2511/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 14: Build Started http://104.196.14.100/job/kudu-gerrit/2510/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#14). Change subject: Memory tracking for result tracker .. Memory tracking for resul

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 13: (9 comments) http://gerrit.cloudera.org:8080/#/c/3627/13/src/kudu/rpc/result_tracker.cc File src/kudu/

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/3501/6/src/kudu/consensus/raft_consensu

[kudu-CR] KUDU-763 consensus queue metrics on followers are messed up

2016-07-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-763 consensus queue metrics on followers are messed up .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3501/5/src/kudu/consensus/consensus_qu

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#9). Change subject: doxygen for C++ client API .. doxygen for C++ client API If dox

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (2 comments) Will send an update shortly. http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2509/ -- To view, visit http://gerrit.cloudera.org:8080/3619 To u

[kudu-CR] rw mutex: prevent recursive use

2016-07-15 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: rw_mutex: prevent recursive use .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3641 To unsubscribe, visit http://gerrit.cloudera.

[kudu-CR] KUDU-1487 Add instructions for cutting a release

2016-07-15 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1487 Add instructions for cutting a release .. KUDU-1487 Add instructions for cutting a release Change-Id: I5b52edb68d35d07ee50bb3c373bf866560f5bc93 R

[kudu-CR] Make block manager-test work on OS X again

2016-07-15 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Make block_manager-test work on OS X again .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3636/2/src/kudu/fs/block_manager-test.cc File src/kudu/f

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 13: (10 comments) http://gerrit.cloudera.org:8080/#/c/3627/13/src/kudu/rpc/result_tracker.cc File src/kudu/rpc/resu

[kudu-CR] Add port in web ui tables, add role and table name to /tablet page

2016-07-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Add port in web ui tables, add role and table name to /tablet page .. Add port in web ui tables, add role and table name to /tablet page Couple of

[kudu-CR] Add port in web ui tables, add role and table name to /tablet page

2016-07-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Add port in web ui tables, add role and table name to /tablet page .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3553 To

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt: Line 989: add_custom_ta

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 13: Build Started http://104.196.14.100/job/kudu-gerrit/2508/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#13). Change subject: Memory tracking for result tracker .. Memory tracking for resul

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/3627/9/src/kudu/rpc/result_tracker.cc File src/kudu/rp

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#12). Change subject: Memory tracking for result tracker .. Memory tracking for resul

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2507/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2506/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#11). Change subject: Memory tracking for result tracker .. Memory tracking for resul

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Memory tracking for result tracker .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2505/ -- To view, visit http://gerrit.cloudera.org:8080/

[kudu-CR] Memory tracking for result tracker

2016-07-15 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3627 to look at the new patch set (#10). Change subject: Memory tracking for result tracker .. Memory tracking for resul

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (4 comments) Please see the responses in-line. Once the questions are cleared, I'll post the next version. Thanks!

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt: Line 983: set(DOXY_SUBD

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (6 comments) Thank you for review! http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt: L

[kudu-CR] doxygen for C++ client API

2016-07-15 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: doxygen for C++ client API .. Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/3619/8/CMakeLists.txt File CMakeLists.txt: Line 983: set(DOXY_SUBD

[kudu-CR] WIP: Add garbage collection to ResultTracker

2016-07-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP: Add garbage collection to ResultTracker .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3628/5/src/kudu/rpc/result_tracker.cc File src

[kudu-CR] [java client] Integrate with the replay cache

2016-07-15 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Integrate with the replay cache .. Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/3631/4/java/kudu-client/src/main/java/org/ku