[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 12: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3055 To unsubscribe, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 12: Build Started http://104.196.14.100/job/kudu-gerrit/2583/ -- To view, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#12). Change subject: [java client] Redo how we manage exceptions ..

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 11: Build Started http://104.196.14.100/job/kudu-gerrit/2582/ -- To view, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 10: Build Started http://104.196.14.100/job/kudu-gerrit/2576/ -- To view, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#10). Change subject: [java client] Redo how we manage exceptions ..

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-20 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 8: (1 comment)

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-19 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#9). Change subject: [java client] Redo how we manage exceptions ..

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 8: (3 comments)

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-19 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 9: Build Started http://104.196.14.100/job/kudu-gerrit/2552/ -- To view, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 8: (3 comments) Looking great overall.

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-18 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 8: > hm, what's the status on this. Still waiting on Dan? Yeah I told Dan that helping out Adar

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 8: Code-Review+1 Will leave the +2ing for Dan, since he had some comments originally. -- To view, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 7: (2 comments) > (3 comments) > > Only a few nits left. > > When you're done, could you

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 7: (3 comments) Only a few nits left. When you're done, could you make a pass over the client-consuming

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#7). Change subject: [java client] Redo how we manage exceptions .. [java client]

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: (1 comment)

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: (2 comments)

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#6). Change subject: [java client] Redo how we manage exceptions .. [java client]

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: (3 comments)

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-13 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: (16 comments) > (16 comments) > > Definitely make a pass over the Javadoc for: > 1. Adding

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: (16 comments) Definitely make a pass over the Javadoc for: 1. Adding @throws where necessary, and 2.

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-12 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: [java client] Redo how we manage exceptions .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2333/ -- To view, visit

[kudu-CR] [java client] Redo how we manage exceptions

2016-07-12 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3055 to look at the new patch set (#5). Change subject: [java client] Redo how we manage exceptions .. [java client]