Adar Dembo has posted comments on this change. Change subject: Add a request tracker to track client rpc sequence numbers ......................................................................
Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/3078/7/src/kudu/rpc/request_tracker.h File src/kudu/rpc/request_tracker.h: Line 43: // this allows to get the lowest incomplete RPC. When this information is sent Nit: instead of "this allows..." say "we can determine the first incomplete RPC." Line 44: // to the server it can use it to garbage collect rpc results that it might be Nit: RPC, not rpc -- To view, visit http://gerrit.cloudera.org:8080/3078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23201625ca02f244dc94205d88dabc01608de471 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <david.al...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <david.al...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes