[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings in raft_consensus-test.cc In thi

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3289 To unsub

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2029/ -- To view, visit

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3289/2/src/kudu/conse

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#3). Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings in raft_consensus-test.cc In this test we'r

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3289/2/src/kudu/consensus/CMa

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: was looking into updating gmock and it seems like it has moved to a ne

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-21 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: Verified+1 unrelated failure on org.kududb.client.TestTimeouts.org.ku

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: we can will do (disregard the update of this patch) -- To view, visi

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1874/ -- To view, visit

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: https://github.com/google/googletest/issues/533 has some discussion here --

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: could we upgrade/patch gmock instead? -- To view, visit http://gerrit.cloude

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-02 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3289/1/src/kudu/consensus/CMak

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: Verified+1 Unrelated flake. -- To view, visit http://gerrit.cloudera

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-02 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1723/ -- To view, visit

[kudu-CR] Avoid missing 'override' keyword warnings in raft consensus-test.cc

2016-06-02 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/3289 Change subject: Avoid missing 'override' keyword warnings in raft_consensus-test.cc .. Avoid missing 'override' keyword warnings i