[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


KUDU-1471 NPE in AsyncKuduClient from Spark

Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Reviewed-on: http://gerrit.cloudera.org:8080/3243
Reviewed-by: Dan Burkert 
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


Patch Set 4: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Jean-Daniel Cryans (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3243

to look at the new patch set (#4).

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..

KUDU-1471 NPE in AsyncKuduClient from Spark

Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/3243/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


Patch Set 3:

LGTM with the caveat of updating the comment per Todd's suggestion.  I think 
it's worth rushing this into 0.9 even without a unit test.

-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3243/2/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1403: // client2tables is assumed populated upon return of the client
 :   // to avoid race condition it is set with in the synchronized 
block
Mind rewriting this as a proper sentence?


-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Jean-Daniel Cryans (Code Review)]

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3243/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 1402:   this.client2tablets.put(client, new ArrayList());
Can you add a comment why this is important to do it before exiting the 
synchronized blog?


-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] KUDU-1471 NPE in AsyncKuduClient from Spark

[Ted Malaska (Code Review)]

Ted Malaska has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3243

Change subject: KUDU-1471 NPE in AsyncKuduClient from Spark
..

KUDU-1471 NPE in AsyncKuduClient from Spark

Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
---
M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/3243/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3243
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecb0f0f50f62db3a3d5fb10f80da70fedeb2629d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska