[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 9:

Build Started http://104.196.14.100/job/kudu-gerrit/2368/

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 8:

Build Started http://104.196.14.100/job/kudu-gerrit/2335/

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 7:

Build Started http://104.196.14.100/job/kudu-gerrit/2274/

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/2254/

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2243/

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[David Ribeiro Alves (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3504

to look at the new patch set (#5).

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..

Make RequestTracker not return Status on FirstIncomplete()

This addresses Todd's post-commit comment on the fact that 
RequestTracker::FirstIncomplete()
shouldn't return a Status and should return NO_SEQ_NO instead.

Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
---
M src/kudu/rpc/request_tracker-test.cc
M src/kudu/rpc/request_tracker.cc
M src/kudu/rpc/request_tracker.h
3 files changed, 16 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3504/5
-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2156/

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..


Patch Set 2:

unrelated flake 
org.kududb.client.TestStatistics.org.kududb.client.TestStatistics

-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[David Ribeiro Alves (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3504

to look at the new patch set (#2).

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..

Make RequestTracker not return Status on FirstIncomplete()

This addresses Todd's post-commit comment on the fact that 
RequestTracker::FirstIncomplete()
shouldn't return a Status and should return NO_SEQ_NO instead.

Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
---
M src/kudu/rpc/request_tracker-test.cc
M src/kudu/rpc/request_tracker.cc
M src/kudu/rpc/request_tracker.h
3 files changed, 15 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3504/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Make RequestTracker not return Status on FirstIncomplete()

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3504

Change subject: Make RequestTracker not return Status on FirstIncomplete()
..

Make RequestTracker not return Status on FirstIncomplete()

This addresses Todd's post-commit comment on the fact that 
RequestTracker::FirstIncomplete()
shouldn't return a Status and should return NO_SEQ_NO instead.

Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
---
M src/kudu/rpc/request_tracker-test.cc
M src/kudu/rpc/request_tracker.cc
M src/kudu/rpc/request_tracker.h
3 files changed, 13 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3504/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0cdcb2b4c0d2d983bd684b5dccf75a81530da93e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves