[kudu-CR] Make dist test.py work on a symlinked work directory

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make dist_test.py work on a symlinked work directory
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2431/

-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Make dist test.py work on a symlinked work directory

[Mike Percy (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3551

to look at the new patch set (#2).

Change subject: Make dist_test.py work on a symlinked work directory
..

Make dist_test.py work on a symlinked work directory

Previously, if run inside a directory that was partially composed of
symlinks, dist_test.py would not correctly collect and modify the RPATHs
of thirdparty libraries. It would put everything in LD_LIBRARY_PATH.
This could result in errors that looked like the following when trying
to symbolize stack traces under TSAN:

/tmp/run_tha_testQiFa2H/thirdparty/installed/bin/llvm-symbolizer: symbol lookup 
error:
/tmp/run_tha_testQiFa2H/build/dist-test-system-libs/libstdc++.so.6: undefined 
symbol: __tsan_init

With these changes, symbolization works.

run_dist_test.py just has a cosmetic change to rename a variable for
clarity. No functional changes.

Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
---
M build-support/dist_test.py
M build-support/run_dist_test.py
2 files changed, 38 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/51/3551/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Make dist test.py work on a symlinked work directory

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Make dist_test.py work on a symlinked work directory
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2144/

-- 
To view, visit http://gerrit.cloudera.org:8080/3551
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5f5c2f1993ceaa3b3a1d74bae16c6efa2c97d9
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No