[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 6: (5 comments) Thanks for review! Will post update soon. http://gerrit.cloudera.org:8080/#/c/3619/6/CMake

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/3619/6/CMakeLists.txt File CMakeLists.txt: Line 1000: # "m

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/2500/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-14 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#6). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comm

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-13 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3619/5/CMakeLists.txt File CMakeLists.txt: Line 963: f

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3619/5/CMakeLists.txt File CMakeLists.txt: Line 963: find

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-12 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (9 comments) Thank you for the review! I took a look at vera++ as a candidate for syntax rule/style enfo

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-12 Thread Anonymous Coward (Code Review)
Anonymous Coward #206 has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (1 comment) Hi Alexey, This is not a review, only testing my review subscription via this. Also

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: (9 comments) I didn't review the changes in client.h in detail yet, wanted to figure out the infrastructure

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#5). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comm

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/2331/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#4). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comm

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2330/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/2329/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#3). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comm

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2321/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3619 to look at the new patch set (#2). Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comm

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 1: (1 comment) > (3 comments) > > Thank you for review, Mike! > > The auto-generated docs are available a

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 1: (3 comments) Thank you for review, Mike! The auto-generated docs are available at: https://alexeyserbi

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 1: One more thing, we need to document doxygen as a new dependency in the docs. The current docs are here: htt

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 1: (3 comments) Mind posting the generated Doxygen HTML somewhere so we can view the output? http://gerrit.clo

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: client.h: doxygen comments for C++ API .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2311/ -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] client.h: doxygen comments for C++ API

2016-07-11 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/3619 Change subject: client.h: doxygen comments for C++ API .. client.h: doxygen comments for C++ API To generate the Doxygen docs from clien