[kudu-CR] rw mutex: add try lock methods

[Adar Dembo (Code Review)]

Adar Dembo has submitted this change and it was merged.

Change subject: rw_mutex: add try lock methods
..


rw_mutex: add try lock methods

I found these to be useful, so I'm exposing them in our wrapper, and beefing
up kudu::shared_lock accordingly.

Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Reviewed-on: http://gerrit.cloudera.org:8080/3604
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
Reviewed-by: Dan Burkert 
---
M src/kudu/util/locks.h
M src/kudu/util/rw_mutex.cc
M src/kudu/util/rw_mutex.h
3 files changed, 40 insertions(+), 4 deletions(-)

Approvals:
  Dan Burkert: Looks good to me, approved
  Todd Lipcon: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] rw mutex: add try lock methods

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: rw_mutex: add try lock methods
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] rw mutex: add try lock methods

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: rw_mutex: add try lock methods
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] rw mutex: add try lock methods

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: rw_mutex: add try lock methods
..


Patch Set 2:

Build Started http://104.196.14.100/job/kudu-gerrit/2297/

-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] rw mutex: add try lock methods

[Adar Dembo (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3604

to look at the new patch set (#2).

Change subject: rw_mutex: add try lock methods
..

rw_mutex: add try lock methods

I found these to be useful, so I'm exposing them in our wrapper, and beefing
up kudu::shared_lock accordingly.

Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
---
M src/kudu/util/locks.h
M src/kudu/util/rw_mutex.cc
M src/kudu/util/rw_mutex.h
3 files changed, 40 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/3604/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] rw mutex: add try lock methods

[Dan Burkert (Code Review)]

Dan Burkert has posted comments on this change.

Change subject: rw_mutex: add try lock methods
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3604/1/src/kudu/util/locks.h
File src/kudu/util/locks.h:

Line 235: struct try_to_lock_t {};
try_to_lock_t is defined in c++11, could you use that?


Line 251: : m_(NULL) {
I think we typically indent these by 4 spaces.
Also, use nullptr.


-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] rw mutex: add try lock methods

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: rw_mutex: add try lock methods
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2265/

-- 
To view, visit http://gerrit.cloudera.org:8080/3604
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3dd4f406b5f90898870083ed3143667d1627bd6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No