[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237315238 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyThriftServer.scala --- @@ -114,24 +98,56 @@ object LivyThriftServer ext

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237314382 --- Diff: server/src/main/scala/org/apache/livy/LivyConf.scala --- @@ -98,10 +98,78 @@ object LivyConf { val LAUNCH_KERBEROS_REFRESH_INTERVAL =

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237319002 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetTableTypesOperation.scala --- @@ -0,0 +1,63 @@ +/* + *

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237318955 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetCatalogsOperation.scala --- @@ -0,0 +1,62 @@ +/* + * L

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237318294 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/PlainSaslServer.scala --- @@ -0,0 +1,184 @@ +/* + * Licensed t

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237319368 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetTypeInfoOperation.scala --- @@ -0,0 +1,130 @@ +/* + *

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237313919 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/LivyCLIService.scala --- @@ -22,60 +22,57 @@ import java.util import j

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237319439 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/operation/GetTypeInfoOperation.scala --- @@ -0,0 +1,130 @@ +/* + *

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237317373 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthFactory.scala --- @@ -0,0 +1,197 @@ +/* + * Licensed to th

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237316485 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/auth/AuthBridgeServer.scala --- @@ -0,0 +1,301 @@ +/* + * Licensed

[GitHub] incubator-livy pull request #117: [LIVY-502] Remove dependency on hive-exec

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/117#discussion_r237318814 --- Diff: thriftserver/server/src/main/scala/org/apache/livy/thriftserver/cli/ThriftHttpServlet.scala --- @@ -0,0 +1,500 @@ +/* + * Licensed

[GitHub] incubator-livy pull request #128: [LIVY-533] Use setJobGroup/cancelJobGroup ...

2018-11-28 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/128#discussion_r237282583 --- Diff: rsc/src/main/java/org/apache/livy/rsc/driver/JobWrapper.java --- @@ -39,20 +39,27 @@ private final RSCDriver driver; priv

[GitHub] incubator-livy pull request #128: [LIVY-533] Use setJobGroup/cancelJobGroup ...

2018-11-28 Thread bjoernlohrmann
Github user bjoernlohrmann commented on a diff in the pull request: https://github.com/apache/incubator-livy/pull/128#discussion_r237280060 --- Diff: rsc/src/main/java/org/apache/livy/rsc/driver/JobWrapper.java --- @@ -39,20 +39,27 @@ private final RSCDriver driver;

[GitHub] incubator-livy issue #129: [LIVY-535] Fix non-atomic session creation

2018-11-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/incubator-livy/pull/129 The code shouldn't be spending that much time in the synchronized block. It does do quite a lot of things, including spawning a child process, but it doesn't wait for that process to finish or

[GitHub] incubator-livy pull request #130: [LIVY-537] Add hiveconf for setting the nu...

2018-11-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-livy/pull/130 ---

[GitHub] incubator-livy issue #130: [LIVY-537] Add hiveconf for setting the num of ex...

2018-11-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/incubator-livy/pull/130 Merging to master. ---

[GitHub] incubator-livy issue #118: [LIVY-503] Separate thrift server session code in...

2018-11-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/incubator-livy/pull/118 Another unrelated failure. The intersection of the last test runs did pass all the combinations, though. ---

[GitHub] incubator-livy pull request #118: [LIVY-503] Separate thrift server session ...

2018-11-28 Thread vanzin
GitHub user vanzin reopened a pull request: https://github.com/apache/incubator-livy/pull/118 [LIVY-503] Separate thrift server session code in separate module. This change creates a new module ("livy-thriftserver-session") with the code related to the Thrift server that is expec

[GitHub] incubator-livy pull request #118: [LIVY-503] Separate thrift server session ...

2018-11-28 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/incubator-livy/pull/118 ---

[GitHub] incubator-livy issue #118: [LIVY-503] Separate thrift server session code in...

2018-11-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/118 Well, what I meant in the past is that the trick used there was the same used in STS and since the problem was related only to few classes used only in the thriftserver, I couldn't see that

[GitHub] incubator-livy issue #118: [LIVY-503] Separate thrift server session code in...

2018-11-28 Thread vanzin
Github user vanzin commented on the issue: https://github.com/apache/incubator-livy/pull/118 I was using an old beeline (Hive 1.1 I think). The one from the client module was having trouble with kerberos, or maybe the connection URL syntax has changed in 3.0... anyway, didn't get it t

[GitHub] incubator-livy pull request #118: [LIVY-503] Separate thrift server session ...

2018-11-28 Thread vanzin
GitHub user vanzin reopened a pull request: https://github.com/apache/incubator-livy/pull/118 [LIVY-503] Separate thrift server session code in separate module. This change creates a new module ("livy-thriftserver-session") with the code related to the Thrift server that is expec

[GitHub] incubator-livy pull request #118: [LIVY-503] Separate thrift server session ...

2018-11-28 Thread vanzin
Github user vanzin closed the pull request at: https://github.com/apache/incubator-livy/pull/118 ---

[GitHub] incubator-livy issue #129: [LIVY-535] Fix non-atomic session creation

2018-11-28 Thread Jassy1994
Github user Jassy1994 commented on the issue: https://github.com/apache/incubator-livy/pull/129 using synchronize may be very slow when submitted many session concurrently, are there any other solutions to solve this problem with a smaller waiting time increase? ---

[GitHub] incubator-livy issue #118: [LIVY-503] Separate thrift server session code in...

2018-11-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/118 The test failure seems not related, can you please close and re-open for re-triggering the tests? Thanks. ---

[GitHub] incubator-livy issue #118: [LIVY-503] Separate thrift server session code in...

2018-11-28 Thread mgaido91
Github user mgaido91 commented on the issue: https://github.com/apache/incubator-livy/pull/118 @vanzin which beeline/hive version are you using? Using the client from the client module or a beeline using Apache Hive 3.0 should work. Yes the tests are UTs rather than ITs, since