yiheng commented on a change in pull request #201: [LIVY-639] add start time
and completion time and duration to the statements web ui
URL: https://github.com/apache/incubator-livy/pull/201#discussion_r315024386
##########
File path: repl/src/main/scala/org/apache/livy/repl/Session.scala
##########
@@ -147,6 +149,12 @@ class Session(
_statements.toMap
}
+ def nowTime(): String = {
+ import java.time.format.DateTimeFormatter
+ val formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss")
+ return LocalDateTime.now().format(formatter)
Review comment:
How do we handle the timezone? What is the timezone of the returned time
representation?
My concern is if the server and web client are in different timezones, will
there be some confusion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
