[GitHub] jerryshao commented on issue #110: [LIVY-508][Server] Support custom auth filter for livy server

jerryshao commented on issue #110: [LIVY-508][Server] Support custom auth filter for livy server URL: https://github.com/apache/incubator-livy/pull/110#issuecomment-459181450 Sorry for the delay, I will address the comments soon.

[GitHub] meisam opened a new pull request #48: [LIVY-41] Let users access sessions by session name

meisam opened a new pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48 This commit enables Livy users to access sessions either by names or by auto-generated sessiond id's. It also prevents users from

[GitHub] meisam closed pull request #48: [LIVY-41] Let users access sessions by session name

meisam closed pull request #48: [LIVY-41] Let users access sessions by session name URL: https://github.com/apache/incubator-livy/pull/48 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support

codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#issuecomment-457216469 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/141?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support

codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#issuecomment-457216469 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/141?src=pr=h1) Report > Merging

[GitHub] z-york commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens

z-york commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens URL: https://github.com/apache/incubator-livy/pull/142#discussion_r252408592 ## File path: server/src/main/scala/org/apache/livy/LivyConf.scala ## @@ -168,6

[GitHub] risdenk opened a new pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk opened a new pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141 ## What changes were proposed in this pull request? Currently `proxyuser` is used in batches and sessions for impersonation. This should be

[GitHub] risdenk closed pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk closed pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] vanzin commented on issue #110: [LIVY-508][Server] Support custom auth filter for livy server

vanzin commented on issue #110: [LIVY-508][Server] Support custom auth filter for livy server URL: https://github.com/apache/incubator-livy/pull/110#issuecomment-459044427 I think it's fine to merge, I just had a nit comment.

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252333071 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala ## @@ -57,10

[GitHub] codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support

codecov-io edited a comment on issue #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#issuecomment-457216469 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/141?src=pr=h1) Report > Merging

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252296678 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala ## @@ -57,10

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252294370 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -183,11

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252285618 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -183,11

[GitHub] risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

risdenk commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252276284 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala ## @@ -57,10

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252155798 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSessionServlet.scala ## @@

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252149000 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,43

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252155964 ## File path: server/src/main/scala/org/apache/livy/sessions/Session.scala ## @@ -204,7 +204,7 @@

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252153640 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -156,9

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252149530 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -156,9

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252153677 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -156,9

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252149231 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,43

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252155857 ## File path: server/src/main/scala/org/apache/livy/server/interactive/InteractiveSession.scala ##

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252156448 ## File path: server/src/test/scala/org/apache/livy/server/BaseSessionServletSpec.scala ## @@

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252154524 ## File path: server/src/main/scala/org/apache/livy/server/SessionServlet.scala ## @@ -183,11

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252149380 ## File path: server/src/main/scala/org/apache/livy/server/AccessManager.scala ## @@ -98,46 +99,43

[GitHub] mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support

mgaido91 commented on a change in pull request #141: [LIVY-551] Add "doAs" impersonation support URL: https://github.com/apache/incubator-livy/pull/141#discussion_r252155202 ## File path: server/src/main/scala/org/apache/livy/server/batch/BatchSession.scala ## @@ -57,10