[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321127246 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321128060 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321127849 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321127396 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321128139 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-05 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r321128758 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319718650 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319718532 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319718631 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319718675 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: @jerryshao @vanzin

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-31 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319718637 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319554599 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: ah I think now I

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319484960 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: isn't it enough to

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319394425 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319393996 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319392310 ## File path: .travis.yml ## @@ -24,16 +24,22 @@ matrix: include: - name: "Spark 2.2 Unit Tests"

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319392841 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-30 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319392575 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: why do we need

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319053994 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319053437 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319026311 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319027951 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-08-29 Thread GitBox
mgaido91 commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r319029075 ## File path: thriftserver/server/src/test/scala/org/apache/livy/thriftserver/ThriftServerSuites.scala