[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r334233145
##
File path:
server/src/main/scala/org/apache/livy/server/auth/LdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.io.IOException
+import java.nio.charset.StandardCharsets
+import java.util
+import java.util.Properties
+import javax.naming.NamingException
+import javax.naming.directory.InitialDirContext
+import javax.naming.ldap.{InitialLdapContext, StartTlsRequest,
StartTlsResponse}
+import javax.net.ssl.{HostnameVerifier, SSLSession}
+import javax.servlet.ServletException
+import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import
org.apache.hadoop.security.authentication.server.{AuthenticationHandler,
AuthenticationToken}
+
+import org.apache.livy._
+
+object LdapAuthenticationHandlerImpl {
+
+ val AUTHORIZATION_SCHEME = "Basic"
+ val TYPE = "ldap"
+ val SECURITY_AUTHENTICATION = "simple"
+ val PROVIDER_URL = "ldap.providerurl"
+ val BASE_DN = "ldap.basedn"
+ val LDAP_BIND_DOMAIN = "ldap.binddomain"
+ val ENABLE_START_TLS = "ldap.enablestarttls"
+
+ private def hasDomain(userName: String): Boolean = {
+indexOfDomainMatch(userName) > 0
+ }
+
+ /**
+* Get the index separating the user name from domain name (the user's name
up
+* to the first '/' or '@').
+*/
+ private def indexOfDomainMatch(userName: String): Int = {
+val idx = userName.indexOf('/')
+val idx2 = userName.indexOf('@')
+// Use the earlier match.
+var endIdx = Math.min(idx, idx2)
+
+// If neither '/' nor '@' was found, using the latter
+if (endIdx == -1) Math.max(idx, idx2) else endIdx
+ }
+}
+
+class LdapAuthenticationHandlerImpl extends AuthenticationHandler with Logging
{
+ private var ldapDomain = "null"
+ private var baseDN = "null"
+ private var providerUrl = "null"
+ private var enableStartTls = false
+ private var disableHostNameVerification = false
+
+ def getType: String = LdapAuthenticationHandlerImpl.TYPE
+
+ @throws[ServletException]
+ def init(config: Properties): Unit = {
+this.baseDN = config.getProperty(LdapAuthenticationHandlerImpl.BASE_DN)
+this.providerUrl =
config.getProperty(LdapAuthenticationHandlerImpl.PROVIDER_URL)
+this.ldapDomain =
config.getProperty(LdapAuthenticationHandlerImpl.LDAP_BIND_DOMAIN)
+this.enableStartTls =
config.getProperty(LdapAuthenticationHandlerImpl.ENABLE_START_TLS,
Review comment:
nit:
```
this.enableStartTls = config.getProperty(
LdapAuthenticationHandlerImpl.ENABLE_START_TLS, "false").toBoolean
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r334233110
##
File path:
server/src/main/scala/org/apache/livy/server/auth/LdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,222 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.io.IOException
+import java.nio.charset.StandardCharsets
+import java.util
+import java.util.Properties
+import javax.naming.NamingException
+import javax.naming.directory.InitialDirContext
+import javax.naming.ldap.{InitialLdapContext, StartTlsRequest,
StartTlsResponse}
+import javax.net.ssl.{HostnameVerifier, SSLSession}
+import javax.servlet.ServletException
+import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import
org.apache.hadoop.security.authentication.server.{AuthenticationHandler,
AuthenticationToken}
+
+import org.apache.livy._
+
+object LdapAuthenticationHandlerImpl {
+
+ val AUTHORIZATION_SCHEME = "Basic"
+ val TYPE = "ldap"
+ val SECURITY_AUTHENTICATION = "simple"
+ val PROVIDER_URL = "ldap.providerurl"
+ val BASE_DN = "ldap.basedn"
+ val LDAP_BIND_DOMAIN = "ldap.binddomain"
+ val ENABLE_START_TLS = "ldap.enablestarttls"
+
+ private def hasDomain(userName: String): Boolean = {
+indexOfDomainMatch(userName) > 0
+ }
+
+ /**
+* Get the index separating the user name from domain name (the user's name
up
+* to the first '/' or '@').
+*/
+ private def indexOfDomainMatch(userName: String): Int = {
+val idx = userName.indexOf('/')
+val idx2 = userName.indexOf('@')
+// Use the earlier match.
+var endIdx = Math.min(idx, idx2)
Review comment:
```suggestion
val endIdx = Math.min(idx, idx2)
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r334233247
##
File path:
server/src/main/scala/org/apache/livy/server/auth/LdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.io.IOException
+import java.nio.charset.StandardCharsets
+import java.util
+import java.util.Properties
+import javax.naming.NamingException
+import javax.naming.directory.InitialDirContext
+import javax.naming.ldap.{InitialLdapContext, StartTlsRequest,
StartTlsResponse}
+import javax.net.ssl.{HostnameVerifier, SSLSession}
+import javax.servlet.ServletException
+import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import
org.apache.hadoop.security.authentication.server.{AuthenticationHandler,
AuthenticationToken}
+
+import org.apache.livy._
+
+object LdapAuthenticationHandlerImpl {
+
+ val AUTHORIZATION_SCHEME = "Basic"
+ val TYPE = "ldap"
+ val SECURITY_AUTHENTICATION = "simple"
+ val PROVIDER_URL = "ldap.providerurl"
+ val BASE_DN = "ldap.basedn"
+ val LDAP_BIND_DOMAIN = "ldap.binddomain"
+ val ENABLE_START_TLS = "ldap.enablestarttls"
+
+ private def hasDomain(userName: String): Boolean = {
+indexOfDomainMatch(userName) > 0
+ }
+
+ /**
+ * Get the index separating the user name from domain name (the user's name
up
+ * to the first '/' or '@').
+ */
+ private def indexOfDomainMatch(userName: String): Int = {
+if (userName == null) {
+ -1
+} else {
+ val idx = userName.indexOf('/')
+ val idx2 = userName.indexOf('@')
+ // Use the earlier match.
+ var endIdx = Math.min(idx, idx2)
+
+ // Unless at least one of '/' or '@' was not found, in
+ // which case, user the latter match.
+ if (endIdx == -1) Math.max(idx, idx2) else endIdx
+}
+ }
+}
+
+class LdapAuthenticationHandlerImpl extends AuthenticationHandler with Logging
{
+ private var ldapDomain = "null"
+ private var baseDN = "null"
+ private var providerUrl = "null"
+ private var enableStartTls = false
+ private var disableHostNameVerification = false
+
+ def getType: String = LdapAuthenticationHandlerImpl.TYPE
+
+ @throws[ServletException]
+ def init(config: Properties): Unit = {
+this.baseDN = config.getProperty(LdapAuthenticationHandlerImpl.BASE_DN)
+this.providerUrl =
config.getProperty(LdapAuthenticationHandlerImpl.PROVIDER_URL)
+this.ldapDomain =
config.getProperty(LdapAuthenticationHandlerImpl.LDAP_BIND_DOMAIN)
+this.enableStartTls =
config.getProperty(LdapAuthenticationHandlerImpl.ENABLE_START_TLS,
+ "false").toBoolean
+require(this.providerUrl != null, "The LDAP URI can not be null")
+
+if (this.enableStartTls.booleanValue) {
+ require(!this.providerUrl.toLowerCase.startsWith("ldaps"),
+"Can not use ldaps and StartTLS option at the same time")
+}
+ }
+
+ def destroy(): Unit = { }
+
+ @throws[IOException]
+ @throws[AuthenticationException]
+ def managementOperation(token: AuthenticationToken, request:
HttpServletRequest,
+response: HttpServletResponse) : Boolean = true
+
+ @throws[IOException]
+ @throws[AuthenticationException]
+ def authenticate(
+request: HttpServletRequest,
+response: HttpServletResponse): AuthenticationToken = {
+var token: AuthenticationToken = null
+var authorization = request.getHeader("Authorization")
+var regionMatch = false
+if (authorization != null) regionMatch = authorization.regionMatches(
+ true,
+ 0,
+ LdapAuthenticationHandlerImpl.AUTHORIZATION_SCHEME,
+ 0,
+ LdapAuthenticationHandlerImpl.AUTHORIZATION_SCHEME.length
+)
+
+if (authorization != null && regionMatch) {
+ authorization = authorization.substring("Basic".length).trim
+ val base64 = new Base64(0)
+ val credentials = new String(base64.decode(authorization),
+StandardCharsets.UTF_8).split(":", 2)
+
+
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r329610645
##
File path:
server/src/main/scala/org/apache/livy/server/auth/LdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.io.IOException
+import java.nio.charset.StandardCharsets
+import java.util
+import java.util.Properties
+import javax.naming.NamingException
+import javax.naming.directory.InitialDirContext
+import javax.naming.ldap.{InitialLdapContext, StartTlsRequest,
StartTlsResponse}
+import javax.net.ssl.{HostnameVerifier, SSLSession}
+import javax.servlet.ServletException
+import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import
org.apache.hadoop.security.authentication.server.{AuthenticationHandler,
AuthenticationToken}
+
+import org.apache.livy._
+
+object LdapAuthenticationHandlerImpl {
+
+ val AUTHORIZATION_SCHEME = "Basic"
+ val TYPE = "ldap"
+ val SECURITY_AUTHENTICATION = "simple"
+ val PROVIDER_URL = "ldap.providerurl"
+ val BASE_DN = "ldap.basedn"
+ val LDAP_BIND_DOMAIN = "ldap.binddomain"
+ val ENABLE_START_TLS = "ldap.enablestarttls"
+
+ private def hasDomain(userName: String): Boolean = {
+indexOfDomainMatch(userName) > 0
+ }
+
+ /**
+ * Get the index separating the user name from domain name (the user's name
up
+ * to the first '/' or '@').
+ */
+ private def indexOfDomainMatch(userName: String): Int = {
+if (userName == null) {
+ -1
+} else {
+ val idx = userName.indexOf('/')
+ val idx2 = userName.indexOf('@')
+ // Use the earlier match.
+ var endIdx = Math.min(idx, idx2)
+
+ // Unless at least one of '/' or '@' was not found, in
+ // which case, user the latter match.
+ if (endIdx == -1) Math.max(idx, idx2) else endIdx
+}
+ }
+}
+
+class LdapAuthenticationHandlerImpl extends AuthenticationHandler with Logging
{
+ private var ldapDomain = "null"
+ private var baseDN = "null"
+ private var providerUrl = "null"
+ private var enableStartTls = false
+ private var disableHostNameVerification = false
+
+ def getType: String = LdapAuthenticationHandlerImpl.TYPE
+
+ @throws[ServletException]
+ def init(config: Properties): Unit = {
+this.baseDN = config.getProperty(LdapAuthenticationHandlerImpl.BASE_DN)
+this.providerUrl =
config.getProperty(LdapAuthenticationHandlerImpl.PROVIDER_URL)
+this.ldapDomain =
config.getProperty(LdapAuthenticationHandlerImpl.LDAP_BIND_DOMAIN)
+this.enableStartTls =
config.getProperty(LdapAuthenticationHandlerImpl.ENABLE_START_TLS,
+ "false").toBoolean
+require(this.providerUrl != null, "The LDAP URI can not be null")
+
+if (this.enableStartTls.booleanValue) {
+ require(!this.providerUrl.toLowerCase.startsWith("ldaps"),
+"Can not use ldaps and StartTLS option at the same time")
+}
+ }
+
+ def destroy(): Unit = { }
+
+ @throws[IOException]
+ @throws[AuthenticationException]
+ def managementOperation(token: AuthenticationToken, request:
HttpServletRequest,
+response: HttpServletResponse) : Boolean = true
+
+ @throws[IOException]
+ @throws[AuthenticationException]
+ def authenticate(
+request: HttpServletRequest,
+response: HttpServletResponse): AuthenticationToken = {
+var token: AuthenticationToken = null
+var authorization = request.getHeader("Authorization")
+var regionMatch = false
+if (authorization != null) regionMatch = authorization.regionMatches(
+ true,
+ 0,
+ LdapAuthenticationHandlerImpl.AUTHORIZATION_SCHEME,
+ 0,
+ LdapAuthenticationHandlerImpl.AUTHORIZATION_SCHEME.length
+)
+
+if (authorization != null && regionMatch) {
+ authorization = authorization.substring("Basic".length).trim
+ val base64 = new Base64(0)
+ val credentials = new String(base64.decode(authorization),
+StandardCharsets.UTF_8).split(":", 2)
+
+
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r329609100
##
File path:
server/src/main/scala/org/apache/livy/server/auth/LdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,231 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.io.IOException
+import java.nio.charset.StandardCharsets
+import java.util
+import java.util.Properties
+import javax.naming.NamingException
+import javax.naming.directory.InitialDirContext
+import javax.naming.ldap.{InitialLdapContext, StartTlsRequest,
StartTlsResponse}
+import javax.net.ssl.{HostnameVerifier, SSLSession}
+import javax.servlet.ServletException
+import javax.servlet.http.{HttpServletRequest, HttpServletResponse}
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import
org.apache.hadoop.security.authentication.server.{AuthenticationHandler,
AuthenticationToken}
+
+import org.apache.livy._
+
+object LdapAuthenticationHandlerImpl {
+
+ val AUTHORIZATION_SCHEME = "Basic"
+ val TYPE = "ldap"
+ val SECURITY_AUTHENTICATION = "simple"
+ val PROVIDER_URL = "ldap.providerurl"
+ val BASE_DN = "ldap.basedn"
+ val LDAP_BIND_DOMAIN = "ldap.binddomain"
+ val ENABLE_START_TLS = "ldap.enablestarttls"
+
+ private def hasDomain(userName: String): Boolean = {
+indexOfDomainMatch(userName) > 0
+ }
+
+ /**
+ * Get the index separating the user name from domain name (the user's name
up
+ * to the first '/' or '@').
+ */
+ private def indexOfDomainMatch(userName: String): Int = {
+if (userName == null) {
Review comment:
how can this happen?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r328054071
##
File path:
server/src/test/scala/org/apache/livy/server/auth/TestLdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.util.Properties
+import javax.servlet.http.HttpServletRequest
+import javax.servlet.http.HttpServletResponse
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.directory.server.annotations.CreateLdapServer
+import org.apache.directory.server.annotations.CreateTransport
+import org.apache.directory.server.core.annotations.ApplyLdifs
+import org.apache.directory.server.core.annotations.ContextEntry
+import org.apache.directory.server.core.annotations.CreateDS
+import org.apache.directory.server.core.annotations.CreatePartition
+import org.apache.directory.server.core.integ.AbstractLdapTestUnit
+import org.apache.directory.server.core.integ.FrameworkRunner
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import org.junit.Assert
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.Mockito
+
+/**
+ * This unit test verifies the functionality of LdapAuthenticationHandlerImpl.
+ */
+@RunWith(classOf[FrameworkRunner])
+@CreateLdapServer(transports = Array(new CreateTransport(protocol = "LDAP",
address = "localhost")))
+@CreateDS(allowAnonAccess = true, partitions = Array(new CreatePartition(name
= "Test_Partition",
+ suffix = "dc=example,dc=com", contextEntry = new ContextEntry(entryLdif =
"dn: dc=example," +
+ "dc=com \ndc: example\nobjectClass: top\n" + "objectClass: domain\n\n"
+@ApplyLdifs(Array("dn: uid=bjones,dc=example,dc=com", "cn: Bob Jones", "sn:
Jones",
+ "objectClass: inetOrgPerson", "uid: bjones", "userPassword: p@ssw0rd"))
+class TestLdapAuthenticationHandlerImpl extends AbstractLdapTestUnit {
+ private var handler: LdapAuthenticationHandlerImpl = null
Review comment:
why not creating here as a val and just init the params in the setup?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r328053692
##
File path:
server/src/test/scala/org/apache/livy/server/auth/TestLdapAuthenticationHandlerImpl.scala
##
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.livy.server.auth
+
+import java.util.Properties
+import javax.servlet.http.HttpServletRequest
+import javax.servlet.http.HttpServletResponse
+
+import org.apache.commons.codec.binary.Base64
+import org.apache.directory.server.annotations.CreateLdapServer
+import org.apache.directory.server.annotations.CreateTransport
+import org.apache.directory.server.core.annotations.ApplyLdifs
+import org.apache.directory.server.core.annotations.ContextEntry
+import org.apache.directory.server.core.annotations.CreateDS
+import org.apache.directory.server.core.annotations.CreatePartition
+import org.apache.directory.server.core.integ.AbstractLdapTestUnit
+import org.apache.directory.server.core.integ.FrameworkRunner
+import org.apache.hadoop.security.authentication.client.AuthenticationException
+import org.junit.Assert
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+import org.mockito.Mockito
+
+/**
+ * This unit test verifies the functionality of LdapAuthenticationHandlerImpl.
+ */
+@RunWith(classOf[FrameworkRunner])
+@CreateLdapServer(transports = Array(new CreateTransport(protocol = "LDAP",
address = "localhost")))
+@CreateDS(allowAnonAccess = true, partitions = Array(new CreatePartition(name
= "Test_Partition",
+ suffix = "dc=example,dc=com", contextEntry = new ContextEntry(entryLdif =
"dn: dc=example," +
+ "dc=com \ndc: example\nobjectClass: top\n" + "objectClass: domain\n\n"
+@ApplyLdifs(Array("dn: uid=bjones,dc=example,dc=com", "cn: Bob Jones", "sn:
Jones",
+ "objectClass: inetOrgPerson", "uid: bjones", "userPassword: p@ssw0rd"))
+class TestLdapAuthenticationHandlerImpl extends AbstractLdapTestUnit {
Review comment:
```suggestion
class TestLdapAuthenticationHandlerImpl extends AbstractLdapTestUnit {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r328052348 ## File path: conf/livy.conf.template ## @@ -160,6 +160,13 @@ # livy.server.auth.kerberos.keytab = # livy.server.auth.kerberos.name-rules = DEFAULT # +# livy.server.auth.type = ldap Review comment: this is still not solved... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325150420 ## File path: conf/livy.conf.template ## @@ -160,6 +160,13 @@ # livy.server.auth.kerberos.keytab = # livy.server.auth.kerberos.name-rules = DEFAULT # +# livy.server.auth.type = ldap Review comment: sounds great. I'd remove it from here anyway. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP
authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325149564
##
File path: server/src/main/scala/org/apache/livy/server/LivyServer.scala
##
@@ -260,6 +261,26 @@ class LivyServer extends Logging {
server.context.addFilter(holder, "/*",
EnumSet.allOf(classOf[DispatcherType]))
info(s"SPNEGO auth enabled (principal = $principal)")
+ case authType @ LdapAuthenticationHandlerImpl.TYPE =>
Review comment:
ah sorry, I rushed checking it, thanks for the explanation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
