yiheng commented on a change in pull request #229: [LIVY-644][TEST] Flaky test:
Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate
(jacoco-report) on project livy-coverage-report
URL: https://github.com/apache/incubator-livy/pull/229#discussion_r323033240
##########
File path: rsc/src/main/java/org/apache/livy/rsc/ContextLauncher.java
##########
@@ -207,7 +207,7 @@ private static ChildProcess startDriver(final RSCConf
conf, Promise<?> promise)
if (!conf.getBoolean(CLIENT_IN_PROCESS) &&
// For tests which doesn't shutdown RscDriver gracefully, JaCoCo exec
isn't dumped properly.
// Disable JaCoCo for this case.
- !conf.getBoolean(TEST_STUCK_END_SESSION)) {
Review comment:
The `conf.getBoolean(TEST_STUCK_END_SESSION)` actually always return false
even the existing code set it to true. Because it uses
`s"${RSCConf.LIVY_SPARK_PREFIX}${RSCConf.Entry.TEST_STUCK_END_SESSION.key()}"`.
In the `ContextLauncher`, the livy spark prefix hasn't been removed.
In this patch, we use a new configuration key
`TEST_NO_CODE_COVERAGE_ANALYSIS`. It should be used in places where the code
coverage should be turned off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
