yiheng commented on a change in pull request #234: [LIVY-683] Livy
SQLInterpreter get empty array when extract date format rows to json
URL: https://github.com/apache/incubator-livy/pull/234#discussion_r325049178
##########
File path: repl/src/main/scala/org/apache/livy/repl/SQLInterpreter.scala
##########
@@ -91,6 +91,9 @@ class SQLInterpreter(
// Convert java BigDecimal type to Scala BigDecimal, because
current version of
// Json4s doesn't support java BigDecimal as a primitive type
(LIVY-455).
case i: java.math.BigDecimal => BigDecimal(i)
+ // Convert java.sql.Date type data to String, because
java.sql.Date cannot extracted
+ // correctly with Json4s (LIVY-683).
+ case d: java.sql.Date => d.toString
Review comment:
Can we have a unit test to cover this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
