---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34908/#review86115
---
Patch looks great!
Reviews applied: [34908]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34195/#review86116
---
Ship it!
Ship It!
- Benjamin Hindman
On May 29, 2015, 1:10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34911/
---
(Updated June 1, 2015, 11:15 p.m.)
Review request for mesos, Ben Mahler, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/#review86113
---
This is great -sorry it took so long to get to do a review.
Thanks
On June 1, 2015, 12:08 a.m., haosdent huang wrote:
src/Makefile.am, line 1465
https://reviews.apache.org/r/34687/diff/4/?file=975082#file975082line1465
seems the order here is follow dictionary order, so how about move them
after `tests/authorization_tests.cpp`?
Note that this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34910/
---
Review request for mesos, Ben Mahler, Ian Downes, Jie Yu, and Joris Van
On June 1, 2015, 7:17 p.m., Ian Downes wrote:
include/mesos/mesos.proto, lines 543-545
https://reviews.apache.org/r/34894/diff/1/?file=975745#file975745line543
What's possible here: can more than one be present or is it only any
one? What's the difference between these?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34911/
---
Review request for mesos, Ben Mahler, Ian Downes, and Jie Yu.
Repository:
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review86122
---
Patch looks great!
Reviews applied: [32891, 32978, 31444]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34899/
---
(Updated June 1, 2015, 11:43 p.m.)
Review request for mesos, Chi Zhang, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated June 2, 2015, 12:02 a.m.)
Review request for mesos, Jie Yu, Niklas
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
---
(Updated June 2, 2015, 12:19 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated June 2, 2015, 12:20 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34830/
---
(Updated June 2, 2015, 12:23 a.m.)
Review request for mesos, Chi Zhang, Ian
On June 2, 2015, 12:57 a.m., Chi Zhang wrote:
Cong, is this the patch the requires code from 3.2.26 for the first time?
If so, should we add a compile-time flag to config.ac? That way Paul can
safely back off the code for the stat string conversion from the other
patch you commented
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/
---
(Updated 六月 2, 2015, 2:29 a.m.)
Review request for mesos.
Bugs: MESOS-2787
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/#review86143
---
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
On 六月 2, 2015, 2:19 a.m., haosdent huang wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 104
https://reviews.apache.org/r/34886/diff/2/?file=976113#file976113line104
You need `git rebase master` first.
thanks, mate, I am not good at this Review board. It's
On June 1, 2015, 6:44 p.m., Cong Wang wrote:
src/linux/routing/queueing/internal.hpp, line 284
https://reviews.apache.org/r/34426/diff/8/?file=975301#file975301line284
The lastest mesos code already relies on libnl 3.2.26, so not sure how
much sense it makes to keep the backward
On June 1, 2015, 1:33 p.m., haosdent huang wrote:
src/cli/mesos-ps, line 105
https://reviews.apache.org/r/34887/diff/1/?file=975642#file975642line105
How about add `bytes = float(bytes)` at the beginning. And don't need
change `1024` to `1024.0` at below code.
weitao zhou
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review86155
---
Ship it!
I added the slave flag for you.
Please follow up with
On June 1, 2015, 6:44 p.m., Cong Wang wrote:
src/linux/routing/queueing/internal.hpp, line 284
https://reviews.apache.org/r/34426/diff/8/?file=975301#file975301line284
The lastest mesos code already relies on libnl 3.2.26, so not sure how
much sense it makes to keep the backward
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
---
(Updated June 2, 2015, 12:40 a.m.)
Review request for mesos, Jie Yu, Niklas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31505/#review86133
---
Cong, is this the patch the requires code from 3.2.26 for the first
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34886/
---
(Updated 六月 2, 2015, 2:14 a.m.)
Review request for mesos.
Bugs: MESOS-2787
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34921/
---
Review request for mesos.
Repository: mesos
Description
---
Code
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34816/
---
(Updated June 2, 2015, 12:38 a.m.)
Review request for mesos, Jie Yu, Niklas
101 - 130 of 130 matches
Mail list logo
