Re: Review Request 36127: Removing '.json' extension in files endpoints url

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36127/#review90378 --- Patch looks great! Reviews applied: [36127] All tests passed. -

Re: Review Request 36181: Port CFS support to Docker Containerizer

2015-07-04 Thread haosdent huang
On July 4, 2015, 5:34 p.m., Timothy Chen wrote: src/slave/containerizer/docker.cpp, line 282 https://reviews.apache.org/r/36181/diff/1/?file=999124#file999124line282 These flags are supported only after a certain docker version right? I think we need to log and disable

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36173/#review90389 --- Patch looks great! Reviews applied: [36173] All tests passed. -

Review Request 36181: Port CFS support to Docker Containerizer

2015-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2154

Re: Review Request 36177: Throw legal ExecutionException in jni calls.

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36177/#review90391 --- Patch looks great! Reviews applied: [36177] All tests passed. -

Re: Review Request 36181: Port CFS support to Docker Containerizer

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/#review90399 --- Patch looks great! Reviews applied: [36181] All tests passed. -

Re: Review Request 36179: Fix duplicate -e environment variables option in Docker::run.

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36179/#review90398 --- Patch looks great! Reviews applied: [36179] All tests passed. -

Review Request 36180: Avoid multi writers write to same file in PortMappingIsolatorTests.

2015-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36180/ --- Review request for mesos and Adam B. Bugs: MESOS-2765

Re: Review Request 36167: Updated FirewallRule interface so is consistent with http::Response usage in the project.

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36167/#review90386 --- Patch looks great! Reviews applied: [36167] All tests passed. -

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90387 --- Patch looks great! Reviews applied: [36106] All tests passed. -

Re: Review Request 32384: Adding perf check to configure

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32384/#review90380 --- Patch looks great! Reviews applied: [32384] All tests passed. -

Re: Review Request 36125: Removing '.json' extension in master endpoints url

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36125/#review90381 --- Patch looks great! Reviews applied: [36125] All tests passed. -

Re: Review Request 36179: Fix duplicate -e environment variables option in Docker::run.

2015-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36179/ --- (Updated July 4, 2015, noon) Review request for mesos, Anindya Sinha and

Re: Review Request 36126: Removing '.json' extension in slave endpoints url

2015-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36126/#review90383 --- Patch looks great! Reviews applied: [36126] All tests passed. -

Review Request 36177: Throw legal ExecutionException in jni calls.

2015-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36177/ --- Review request for mesos. Bugs: MESOS-2718

Review Request 36179: Fix duplicate -e environment variables option in Docker::run.

2015-07-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36179/ --- Review request for mesos, Anindya Sinha and Timothy Chen. Bugs: MESOS-2882