Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 22, 2015, 6:10 a.m.) Review request for mesos, Isabel Jimenez and

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96113 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Aug. 22, 2015, 5:56 a.m.) Review request for mesos, Isabel Jimenez and

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-21 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96112 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Review Request 37700: Document libsasl2-modules as a required dependency when building on ubuntu.

2015-08-21 Thread Andrew Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37700/ --- Review request for mesos. Bugs: MESOS-3305 https://issues.apache.org/jira/b

Review Request 37699: Removed remnants of LIBPROCESS_STATISTICS_WINDOW.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37699/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3304 https://issues.ap

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-21 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 8:54 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
> On Aug. 21, 2015, 6:14 p.m., Jie Yu wrote: > > src/tests/containerizer/rootfs.hpp, lines 111-126 > > > > > > Can you combine the this loop with the loop below (like the following). > > Also, could you use 'realpat

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 7:15 p.m.) Review request for mesos, Marco Massenzio an

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-21 Thread Joseph Wu
> On Aug. 21, 2015, 11:35 a.m., Alexander Rukletsov wrote: > > include/mesos/mesos.proto, lines 917-920 > > > > > > I think the name `Unavailability` is too specific to maintenance, how > > about something more gene

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-21 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 21, 2015, 6:46 p.m.) Review request for mesos and Ben Mahler. R

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96073 --- include/mesos/mesos.proto (lines 917 - 920)

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96068 --- Ship it! Thanks src/tests/containerizer/rootfs.hpp (lines 111 - 1

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-21 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review96064 --- src/tests/flags.hpp (line 86)

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-21 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 21, 2015, 6:05 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/#review96054 --- Ship it! Ship It! - Marco Massenzio On Aug. 21, 2015, 4:51 p.m.,

Re: Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- (Updated Aug. 21, 2015, 4:51 p.m.) Review request for mesos, Marco Massenzio an

Review Request 37684: Added symlink test for /bin, lib, and /lib64.

2015-08-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37684/ --- Review request for mesos, Marco Massenzio and Vinod Kone. Bugs: MESOS-3296 and