Re: Review Request 38244: Renamed Filter to OfferFilter.

2015-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38244/#review99681 --- Ship it! src/master/allocator/mesos/hierarchical.hpp (line 191)

Re: Review Request 38324: Added support for setting accept and decline filters on inverse offers.

2015-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38324/#review99684 --- Ship it! include/mesos/master/allocator.hpp (line 162)

Re: Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38530/ --- (Updated Sept. 20, 2015, 2:07 a.m.) Review request for mesos, Artem

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/ --- (Updated Sept. 20, 2015, 2:07 a.m.) Review request for mesos, Artem

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-19 Thread Marco Massenzio
> On Sept. 18, 2015, 10:57 p.m., Cong Wang wrote: > > Why not just set --host_name=$LIBPROCESS_IP for your case since you anyway > > need to provide a flag? > > Guangya Liu wrote: > I also have the same question with Cong, @Marco, can you please show more > detail for why not using the

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review99692 --- Patch looks great! Reviews applied: [38456, 38457] All tests

Review Request 38528: Disable perf test when perf version is not support.

2015-09-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Bugs:

Re: Review Request 38528: Disable perf test when perf version is not support.

2015-09-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/ --- (Updated Sept. 19, 2015, 7:30 p.m.) Review request for mesos, Joris Van

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
> On Sept. 17, 2015, 4:44 p.m., Marco Massenzio wrote: > > I'm excited about this! > > Tested on OSX and (at least, as far as stout_tests go, it works, yay!) > > > > A quick question: why, instead of moving the files, we don't simply add a > > symlink that will "look right" to the linker etc.

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Marco Massenzio
> On Sept. 17, 2015, 4:44 p.m., Marco Massenzio wrote: > > I'm excited about this! > > Tested on OSX and (at least, as far as stout_tests go, it works, yay!) > > > > A quick question: why, instead of moving the files, we don't simply add a > > symlink that will "look right" to the linker etc.

Re: Review Request 38528: Disable perf test when perf version is not support.

2015-09-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/ --- (Updated Sept. 20, 2015, 2:49 a.m.) Review request for mesos, Joris Van

Re: Review Request 38528: Disable perf test when perf version is not support.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/#review99696 --- Patch looks great! Reviews applied: [38528] All tests passed. -

Re: Review Request 38528: Disable perf test when perf version is not support.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38528/#review99686 --- Patch looks great! Reviews applied: [38528] All tests passed. -

Re: Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38531/ --- (Updated Sept. 20, 2015, 2:07 a.m.) Review request for mesos, Artem

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 20, 2015, 1:25 a.m.) Review request for mesos, Artem

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 20, 2015, 2:03 a.m.) Review request for mesos, Artem

Re: Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38531/#review99693 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530,

Re: Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/#review99685 --- Patch looks great! Reviews applied: [38527] All tests passed. -

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-19 Thread Alex Clemmer
> On Sept. 18, 2015, 9:10 p.m., Joseph Wu wrote: > > You should consider adding a CMake macro to make this more maintainable. > > > > A macro that does something like: > > ``` > > mkdir -p ${INPUT_SRC}-lib/lib > > && cp -r ${INPUT_SRC}-build/lib/.libs/. ${INPUT_SRC}-lib/lib > > ``` I actually

Review Request 38527: Fix UserCgroupIsolatorTest failed on CentOS 6.6.

2015-09-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38527/ --- Review request for mesos. Repository: mesos Description --- Fix

Re: Review Request 38246: Added propagation of Resources and Unavailability from the InverseOffer protobuf to the allocator.

2015-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38246/#review99683 --- Ship it! include/mesos/master/allocator.hpp (line 156)

Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38531/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.

2015-09-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38530/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

2015-09-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38532/ --- Review request for mesos, Joris Van Remoortere and Michael Park. Bugs:

Re: Review Request 38251: FrameworkInfo should only be updated if the re-registration is valid

2015-09-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38251/#review99678 --- Ship it! Refactored a little as per Anand's suggestion. - Joris

Re: Review Request 38475: Maintenance Primitives: Add test for inverse offer filters.

2015-09-19 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38475/ --- (Updated Sept. 19, 2015, 6:14 p.m.) Review request for mesos, Artem

Re: Review Request 38519: Change function quiesce() to suppressRes()

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38519/#review99655 --- Patch looks great! Reviews applied: [38514, 38516, 38519] All

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99656 --- Bad patch! Reviews applied: [37585] Failed command:

Re: Review Request 38473: Add flag to disable hostname lookup.

2015-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38473/#review99658 --- Patch looks great! Reviews applied: [38473] All tests passed. -