Re: Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38551/#review100739 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 6:30 p.m.,

Re: Review Request 38529: CMake: Only compile proc_tests.cpp for Linux platforms.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38529/#review100722 --- Ship it! - Joris Van Remoortere On Sept. 20, 2015, 2:07 a.m.,

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38753/ --- (Updated Sept. 26, 2015, 6 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38540/#review100731 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:41 a.m.,

Re: Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/#review100729 --- Ship it! hausdorff will follow up with a JIRA for preventing 32

Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38538/#review100726 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:33 a.m.,

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/#review100741 --- Ship it!

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38549/#review100735 --- Ship it! This is a big decision because on linux right now the

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/#review100721 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 2:43 a.m.,

Re: Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38542/#review100733 --- Ship it! This is great Alex! - Joris Van Remoortere On Sept.

Re: Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38552/#review100740 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 11:21 a.m.,

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/#review100738 --- Ship it! - Joris Van Remoortere On Sept. 21, 2015, 10:43 a.m.,

Re: Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38541/#review100732 --- Ship it! - Joris Van Remoortere On Sept. 25, 2015, 10:09 p.m.,

Re: Review Request 38531: CMake: Update CMake config to build Mesos against picojson v1.3.0.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38531/#review100725 --- Ship it! - Joris Van Remoortere On Sept. 20, 2015, 2:07 a.m.,

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38751/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38551: [1/2]CMake: Add version info for APR we need to build Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38551/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38552: [2/2]CMake: Add Windows-specific build targets for APR.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38552/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38752: CMake: Update MesosConfigure to use new process configure scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38752/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38754: CMake: Add build/configure/install logic for Zookeeper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38754/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38753: CMake: Transition Stout tests to use new third-party build scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38753/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38774: state: fix file descriptor leak

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38774/#review100765 --- Is there already an RAII wrapper for os::close() we can use? If

Re: Review Request 38756: CMake: Add support for compiling the agent with CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38756/ --- (Updated Sept. 26, 2015, 10:57 p.m.) Review request for mesos, Artem

Review Request 38793: CMake: Transition to CMake-based build system for GMock/GTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38793/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38549: [1/2]CMake: Add libevent version, configure Windows to use as default.

> On Sept. 26, 2015, 6:09 a.m., Joris Van Remoortere wrote: > > This is a big decision because on linux right now the default is libev. The > > code paths are significantly different between libev and libevent. > > hausdorff is going to follow up with a JIRA for this, and force users to > >

Re: Review Request 38550: [2/2]CMake: Integrate libevent into Windows builds.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38550/ --- (Updated Sept. 26, 2015, 10:03 p.m.) Review request for mesos, Artem

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

> On Sept. 25, 2015, 7:07 a.m., Alex Clemmer wrote: > > cmake/CompilationConfigure.cmake, line 97 > > > > > > Oh yeah. I forgot to remove these. I don't actually know what > > `pkglibexecdir` does in autoconf; I'll

Re: Review Request 38751: CMake: Pull third-party configuration logic into its own .cmake file.

> On Sept. 26, 2015, 6:10 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake, line 82 > > > > > > Do we not need lflags for libevent? > > Alex Clemmer wrote: > The

Re: Review Request 38793: CMake: Transition to CMake-based build system for GMock/GTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38793/#review100767 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/#review100770 --- Patch looks great! Reviews applied: [38705] All tests passed. -

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- (Updated Sept. 27, 2015, 1:34 a.m.) Review request for mesos, Alexander

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

> On Sept. 24, 2015, 5:38 p.m., Joseph Wu wrote: > > support/apply-reviews.py, line 13 > > > > > > Might be cleaner/safer to use urlparse.urljoin for this: > >

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38705/ --- (Updated Sept. 26, 2015, 7:02 p.m.) Review request for mesos, Joris Van