Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 4:17 p.m., Alexander Rukletsov wrote: > > One high level suggestion. > > > > After looking at our http code, I realized that we use the same pattern > > again and again, for example: > > ``` > > JSON::Array array; > >

Re: Review Request 38900: Update command executor to support rootfs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38900/#review101431 --- Patch looks great! Reviews applied: [38900] All tests passed. -

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38532/#review101435 --- src/tests/containerizer/cgroups_tests.cpp (line 1054)

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101436 --- Patch looks great! Reviews applied: [37023] All tests passed. -

Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-2953

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38532/#review101442 --- Patch looks great! Reviews applied: [38532] All tests passed. -

Review Request 38979: TestContainerizer should not modify global environment variables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38979/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3475

Re: Review Request 36181: Port CFS support to Docker Containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/#review101441 --- Patch looks great! Reviews applied: [36181] All tests passed. -

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 1:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 1:07 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38978: Add post-rewrite hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38978/#review101443 --- Patch looks great! Reviews applied: [38978] All tests passed. -

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 10:43 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, line 166 > > > > > > See my comment above. I think you should not repeat testing

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

> On Sept. 29, 2015, 4:17 p.m., Alexander Rukletsov wrote: > > One high level suggestion. > > > > After looking at our http code, I realized that we use the same pattern > > again and again, for example: > > ``` > > JSON::Array array; > >

Re: Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38342/ --- (Updated Oct. 4, 2015, 11:29 a.m.) Review request for mesos, Alexander

Re: Review Request 38532: Add error message when cgroup don't support memory.pressure_level.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38532/ --- (Updated Oct. 4, 2015, 6:59 a.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 38961: Simplified resources initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38961/#review101437 --- Ship it! Ship It! - Guangya Liu On 十月 2, 2015, 5:10 p.m.,

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/ --- (Updated Oct. 4, 2015, 6:26 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/ --- (Updated Oct. 4, 2015, 6:27 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37023: Add an endpoint that exposes component flags.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37023/#review101434 --- Ship it! Ship It! - Guangya Liu On 十月 4, 2015, 6:27 a.m.,

Re: Review Request 36181: Port CFS support to Docker Containerizer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36181/ --- (Updated Oct. 4, 2015, 6:40 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

> On Oct. 4, 2015, 2:09 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 463 > > > > > > Is it possible to add a unit test for this change? Because it depends on install and configure flocker in host, I not

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

> On Oct. 4, 2015, 2:09 a.m., Guangya Liu wrote: > > include/mesos/mesos.proto, line 1443 > > > > > > Does v1 also needs to be updated? I notice we have some inconsistent between v1 and current proto, so I not

Re: Review Request 38899: Added handler for Executor->Framework message for the Executor HTTP API

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38899/#review101439 --- src/slave/http.cpp (line 316)

Re: Review Request 38960: Add QuotaInfo Protobuf to CMake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38960/#review101440 --- Ship it! Ship It! - Guangya Liu On 十月 2, 2015, 4:51 p.m.,

Re: Review Request 38705: Added support for applying a review chain (apply-reviews.py).

> On 十月 1, 2015, 1:12 p.m., Guangya Liu wrote: > > support/apply-reviews.py, line 2 > > > > > > The import should be in alpha order > > Artem Harutyunyan wrote: > I am happy to fix this, but could you please

Re: Review Request 38338: Enhanced option for Docker cli volume plugin.

> On 十月 4, 2015, 2:09 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, line 463 > > > > > > Is it possible to add a unit test for this change? > > haosdent huang wrote: > Because it depends on install and

Review Request 38986: Add VersionProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38986/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1841

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 2:39 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 2:25 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37024: Exposes mesos version information in components.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/ --- (Updated Oct. 4, 2015, 3:12 p.m.) Review request for mesos and Ben Mahler.