Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated March 9, 2016, 9:47 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
> On March 9, 2016, 8:26 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 89 > > > > > > We don't (yet) use `CHECK_GE/LE/GT/LT` anywhere, I think because we > > want tests themselves to try to be ex

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-09 Thread Alexander Rojas
> On March 9, 2016, 10:18 a.m., Adam B wrote: > > src/master/master.cpp, line 2801 > > > > > > Someday we may want to return something besides a bool, so that the > > client can get back a more meaningful error tha

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122699 --- A couple of quick thoughts on your WIP so far. Also, I committed t

Re: Review Request 44322: Implemented a generalized interface for the authorizer.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44322/#review122700 --- Bad patch! Reviews applied: [44322, 44320, 44319, 44318] Failed

Re: Review Request 44511: Add registry tests for /weights endpoint.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44511/#review122698 --- Can you please describe in your "Testing Done" section what the ne

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review122696 --- Looks like you bumped this down in the review chain to come last,

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review121134 --- src/tests/dynamic_weights_tests.cpp (line 345)

Re: Review Request 44379: Correctly parse perf stat format for 3.10 kernel.

2016-03-09 Thread fan du
> On 三月 8, 2016, 1:35 a.m., Ben Mahler wrote: > > src/linux/perf.cpp, lines 430-431 > > > > > > Couple of thoughts here: > > > > (1) This comment is no longer accurate since there is a special case > > for

<    1   2