Re: Review Request 50637: Added id to the libprocess Sequence constructor.

2016-08-02 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50637/ --- (Updated Aug. 2, 2016, 1:29 p.m.) Review request for mesos and Alexander Ruklet

Review Request 50706: Added test cases for PARTITION_AWARE behavior.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50706/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50707: Added test for agent removal behavior.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50707/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50705: Changed master to allow partitioned slaves to reregister.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50705/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50704: Made a few minor tweaks to comments.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50704/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50703: Removed a no-longer-relevant test.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50703/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50702: Renamed metrics from "slave_shutdowns" to "slave_unreachable".

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50702/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50701: Added registrar operations for marking agents (un-)reachable.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50701/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50700: Added a list of "unreachable" agents to the registry.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50700/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Review Request 50699: Added new TaskState values and PARTITION_AWARE capability.

2016-08-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50699/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4049 https://issues.ap

Re: Review Request 50677: Renamed `OfferedResources` to `Allocation`.

2016-08-02 Thread Guangya Liu
> On 八月 2, 2016, 12:12 a.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3461-3466 > > > > > > Can we re-use the Allocation struct from above? > > > > > > https://github.co

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144471 --- src/health-check/health_checker.hpp (lines 283 - 284)

Re: Review Request 50695: Renamed agent used resources to `allocation` for benchmark test.

2016-08-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/ --- (Updated 八月 2, 2016, 9:53 a.m.) Review request for mesos and Benjamin Mahler.

Review Request 50695: Renamed agent used resources to `allocation` for benchmark test.

2016-08-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50695/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 50693: Added another function `createSlaveInfo` for allocator benchmark test.

2016-08-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50693/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-08-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review144374 --- include/mesos/mesos.proto (lines 324 - 346)

Re: Review Request 50599: Added a new 'device' entry to 'docker::Flags'.

2016-08-02 Thread Yubo Li
> On 八月 1, 2016, 10:12 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, line 229 > > > > > > You are losing the logic of handling the `device` here: > > > > ``` > > // Exposed devices to

Re: Review Request 49817: Implemented `CgroupsIsolatorProcess::recover`.

2016-08-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49817/ --- (Updated Aug. 2, 2016, 7:33 a.m.) Review request for mesos, Gilbert Song, Jie Y

Re: Review Request 50627: Used `await` instead of `collect` on `Subsystem` operations.

2016-08-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50627/ --- (Updated Aug. 2, 2016, 7:20 a.m.) Review request for mesos, Gilbert Song, Jie Y

<    1   2