Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

2016-10-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review151477 --- src/slave/containerizer/docker.cpp (lines 648 - 649)

Re: Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/#review151929 --- Patch looks great! Reviews applied: [52470, 52520, 52471, 52664]

Review Request 52664: Moved the `decimalFloat` filter to app.js for consistency.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52664/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Re: Review Request 52663: Updated mesos_logo_fb_preview.png.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52663/ --- (Updated Oct. 8, 2016, 4:49 p.m.) Review request for mesos. Repository:

Review Request 52663: Updated mesos_logo_fb_preview.png.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52663/ --- Review request for mesos. Repository: mesos Description --- Updated

Review Request 52662: Fixed incorrect link in getting-started document.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52662/ --- Review request for mesos, Alexander Rukletsov, Jie Yu, and Vinod Kone.

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/#review151926 --- Patch looks great! Reviews applied: [52470, 52520, 52471]

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/#review151924 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 52243: Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryForward`.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52243/ --- (Updated Oct. 8, 2016, 1:52 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52244: Added test case `CgroupsIsolatorTest.ROOT_CGROUPS_MemoryBackward`.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52244/ --- (Updated Oct. 8, 2016, 1:53 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51031: Added non-recursive version of `cgroups::get`.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51031/ --- (Updated Oct. 8, 2016, 12:43 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 51624: Implemented 'GetAgent' call in v1 agent API.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51624/ --- (Updated Oct. 8, 2016, 12:37 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 8, 2016, 12:20 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 8, 2016, 12:20 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52520: Exposed the executor's type in the endpoints.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52520/ --- (Updated Oct. 8, 2016, 12:20 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52470: Set executor id in `protobuf::createTask`.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 8, 2016, 12:19 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 52620: Updated InverseOffers* maintenance tests to use the new scheduler mock.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52620/#review151923 --- Patch looks great! Reviews applied: [52620] Passed command:

Re: Review Request 52653: Modified a test to use the updated Bytes operators.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52653/#review151922 --- Patch looks great! Reviews applied: [52652, 52653] Passed

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52471/ --- (Updated Oct. 8, 2016, 6:11 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52471: Fixed the wrong sandbox directory of the tasks in Web UI.

2016-10-08 Thread haosdent huang
> On Oct. 7, 2016, 7:33 p.m., Vinod Kone wrote: > > src/webui/master/static/js/controllers.js, line 58 > > > > > > s/===/==/ ? In javascript, we prefer `===` instead of `==`, because `==` may true when they are not