Re: Review Request 53532: Added parse helper function to 'Docker::Device'.

> On 十一月 12, 2016, 12:26 p.m., Guangya Liu wrote: > > Summary: > > ``` > > Added `parse` helper function for `Docker::Device`. > > ``` > > > > Description: > > ``` > > Added a new helper function to parse a string to 'Docker::Device' > > 'Docker::Device' structure. The string should be in the

Re: Review Request 50947: Removed isolator flag 'gpu/nvidia' for docker containerizer using GPU.

> On 十一月 12, 2016, 12:14 p.m., Guangya Liu wrote: > > We do not have `external containerizer` now, so you can remove it from the > > `Descripiton`. > > > > Summary > > ``` > > Only check `gpu/nvidia` isolator for mesos containerizer. > > ``` > > > > Description > > ``` > > Mesos containerizer

Re: Review Request 53704: Added a level of indirection for logger through IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/#review155883 --- Patch looks great! Reviews applied: [53704] Passed command:

Review Request 53770: CMake Cleanup: Alphabetize the list of sources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53770/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53769: CMake: Added -fPIC to leveldb build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53769/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53768: CMake Cleanup: Generate protobufs with fewer dependencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53768/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53767: CMake Cleanup: Rename SlaveConfigure.cmake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53767/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53766: CMake: Added option for enabling optimization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53766/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53765: CMake: Revised compilation configuration file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53765/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53764: CMake: Added a target for the default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53764/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53763: CMake: Added binaries as dependencies for MESOS_TARGET.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53763/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53762: CMake: Renamed MESOS_TARGET to MESOS_LIBS_TARGET.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53762/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53760: CMake: Changed example module output location and depedencies.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53760/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53761: CMake: Add a target between MESOS_TARGET and MESOS_PROTOBUFs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53761/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53759: CMake: Change libprocess to a shared library.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53759/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Review Request 53758: CMake: Added test sources to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53758/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Bugs:

Re: Review Request 53757: CMake: Moved logrotate container logger binary build definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53757/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53755: CMake: Added example frameworks and executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53755/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53753: CMake: Added variable for default linking strategy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53753/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53754: CMake: Added test modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53754/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53327/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Review Request 53757: CMake: Moved logrotate container logger binary build definition.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53757/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Re: Review Request 53741: Display maintainance info in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review155882 --- Patch looks great! Reviews applied: [53741] Passed command:

Review Request 53755: CMake: Added example frameworks and executors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53755/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 53754: CMake: Added test modules that are loaded by mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53754/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Review Request 53753: CMake: Added variable for default linking strategy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53753/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository:

Re: Review Request 53327: CMake: Added build variables for Mesos tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53327/ --- (Updated Nov. 14, 2016, 7:03 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53704: Added a level of indirection for logger through IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/ --- (Updated Nov. 15, 2016, 12:19 a.m.) Review request for mesos, Benjamin

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 14, 2016, 4:26 p.m., Abhishek Dasgupta wrote: > > src/cli/execute.cpp, line 342 > > > > > > Should we still continue with our old approach of creating task in > > mesos execute?? You can still continue

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 14, 2016, 9:51 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 14, 2016, 9:52 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 14, 2016, 9:52 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53473: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 14, 2016, 9:52 p.m.) Review request for mesos and Joseph Wu.

Review Request 53741: Display maintainance info in the webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/ --- Review request for mesos, haosdent huang and Joseph Wu. Bugs: MESOS-6443

Re: Review Request 53695: Allows caching extractable files when outputFile is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53695/#review155842 --- Patch looks great! Reviews applied: [53695] Passed command:

Re: Review Request 53313: Windows: Disable persistent state for Windows master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53313/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Daniel Pravat and

Re: Review Request 53688: Implement a namespace/ipc isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53688/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53627: Implement a namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53627/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53690: Add namespaces/ipc documentation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53690/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53626: Add net::setDomainname() helper API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53626/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53628: Document the namespaces/uts isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53628/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53689: Use a common fixture for the PID namespace test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53689/ --- (Updated Nov. 14, 2016, 6:51 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 52308: Add variable user to handle switchUser passed from executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52308/ --- (Updated Nov. 14, 2016, 3:46 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 52310: Switch the uid of the binary if a user is passed from the lib_logrotate.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/ --- (Updated Nov. 14, 2016, 3:46 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53473: Add new param user to logrotate's prepare function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53473/ --- (Updated Nov. 14, 2016, 3:43 p.m.) Review request for mesos and Joseph Wu.

Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-5856

Review Request 53695: Allows caching extractable files when outputFile is set.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53695/ --- Review request for mesos, Gilbert Song and Jie Yu. Bugs: MESOS-6587

Re: Review Request 53693: Added Stephen Hankinson to contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53693/#review155809 --- Ship it! Ship It! - Alexander Rukletsov On Nov. 12, 2016,

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/#review155802 --- Bad patch! Reviews applied: [52873, 52872, 52871, 52870, 52869,

Re: Review Request 52870: Ensured docker executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 14, 2016, 10:36 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52869: Ensured command executor stops health checking terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- (Updated Nov. 14, 2016, 10:35 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 14, 2016, 10:35 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52872: Used callback instead of `send()` for health status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52872/ --- (Updated Nov. 14, 2016, 10:30 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52870: Ensured docker executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52870/ --- (Updated Nov. 14, 2016, 10:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52873: Cleaned up private members in HealthChecker class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52873/ --- (Updated Nov. 14, 2016, 10:30 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52869: Ensured command executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52869/ --- (Updated Nov. 14, 2016, 10:30 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52871: Ensured default executor ignores health updates for terminated tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52871/ --- (Updated Nov. 14, 2016, 10:30 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52868: Added pause/resume functionality to HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52868/ --- (Updated Nov. 14, 2016, 10:29 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 52867: Used `Duration::create()` for double -> Duration conversion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52867/ --- (Updated Nov. 14, 2016, 10:28 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 52866: Refactored HealthChecker::reschedule to take duration as an argument.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52866/ --- (Updated Nov. 14, 2016, 10:28 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52865: Refactored HealthChecker to never stop health checking.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52865/ --- (Updated Nov. 14, 2016, 10:27 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 52864: Removed unnecessary sleep in HealthChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52864/ --- (Updated Nov. 14, 2016, 10:24 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 52863: Refactored HealthCheck validation for clarity.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52863/ --- (Updated Nov. 14, 2016, 10:23 a.m.) Review request for mesos, Gastón Kleiman

Re: Review Request 53704: Added level of indirection for logger through IO Switchboard.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53704/#review155800 --- Patch looks great! Reviews applied: [53704] Passed command:

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155798 --- src/cli/execute.cpp (line 342)

Re: Review Request 53604: Added SeccompInfo protobuf message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53604/ --- (Updated Nov. 14, 2016, 8:09 a.m.) Review request for mesos and Jie Yu.