Review Request 54103: Made MesosContainerizer launch helper to take ContainerLaunchInfo.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54103/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54102: Moved the default PATH setting to containerizer.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54102/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54101: Removed MesosContainerizerLaunchTest.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54101/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54100: Removed two disabled shared filesystem isolator tests.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54100/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54098: Moved a VLOG to a proper place in MesosContainerizer.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54098/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54097: Added support to export the flags as environment variables.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54097/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54099: Used environment to pass flags to launch helper.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54099/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54096: Fixed an indentation problem in Subcommand.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54096/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Review Request 54095: Removed an unused function in launch helper.

2016-11-26 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54095/ --- Review request for mesos, Gilbert Song and Kevin Klues. Bugs: MESOS-6648

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

2016-11-26 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156963 --- src/master/validation.cpp (line 258)

Re: Review Request 50523: Updated docker recovery to account for GPU resources.

2016-11-26 Thread Guangya Liu
> On εδΈ€ζœˆ 5, 2016, 12:56 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 1054-1060 > > > > > > The `recoverDevices` will block here, what about using continuation as > >

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/#review156958 --- Bad patch! Reviews applied: [53699, 53473, 52310, 52308] Failed

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-26 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 26, 2016, 11:50 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53699: Add test cases to test logrotate with switch_user set to true and false.

2016-11-26 Thread Sivaram Kannan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53699/ --- (Updated Nov. 26, 2016, 11:48 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 53288: Show Mesos logo in the navbar brand.

2016-11-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53288/#review156957 --- Patch looks great! Reviews applied: [53287, 53288] Passed

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53995/#review156954 --- Patch looks great! Reviews applied: [54048, 54093, 54039, 53994,

Re: Review Request 53289: Updated favicon.ico.

2016-11-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53289/ --- (Updated Nov. 26, 2016, 5:52 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53288: Show Mesos logo in the navbar brand.

2016-11-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53288/ --- (Updated Nov. 26, 2016, 5:51 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53287: Overrided the default navbar color to match project website.

2016-11-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53287/ --- (Updated Nov. 26, 2016, 5:50 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 53995: Added API handler for ATTACH_CONTAINER_OUTPUT.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53995/ --- (Updated Nov. 26, 2016, 5:43 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54049: Cleaned up includes in tests/api_tests.cpp.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54049/ --- (Updated Nov. 26, 2016, 5:42 p.m.) Review request for mesos and Anand

Re: Review Request 53994: Added streaming support to `/api/v1` handler on the agent.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53994/ --- (Updated Nov. 26, 2016, 5:42 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 54039: Added `recordio::transform` helper.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54039/ --- (Updated Nov. 26, 2016, 5:41 p.m.) Review request for mesos, Anand Mazumdar

Review Request 54093: Refactored recordio::ReaderProcess to be managed by gc.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54093/ --- Review request for mesos, Anand Mazumdar and Benjamin Mahler. Repository:

Re: Review Request 54048: Fixed a bug in scheduler library.

2016-11-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54048/ --- (Updated Nov. 26, 2016, 5:40 p.m.) Review request for mesos and Anand