Re: Review Request 54999: Fixed test flakiness due to floating point conversions.

2016-12-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54999/#review160285 --- Patch looks great! Reviews applied: [54999] Passed command:

Re: Review Request 55068: Added Capabilities to Framework struct of Hierarchical allocator.

2016-12-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55068/#review160282 --- Patch looks great! Reviews applied: [55021, 55066, 55068]

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

2016-12-29 Thread Aaron Wood
> On Dec. 27, 2016, 1:25 p.m., Till Toenshoff wrote: > > 3rdparty/stout/include/stout/os/linux.hpp, line 81 > > > > > > As you have no further use for the returned value, I guess we could > > simply spare the

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

2016-12-29 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/ --- (Updated Dec. 29, 2016, 7:03 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54996: Fix SIGBUS crash on ARM64/AArch64.

2016-12-29 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54996/#review160279 --- 3rdparty/stout/include/stout/os/linux.hpp (lines 76 - 77)

Re: Review Request 55065: Added support for s390x architecture

2016-12-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55065/#review160273 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 50629: Allow using protobuf 3.0 (MESOS-5186).

2016-12-29 Thread Deshi Xiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50629/#review160272 --- good for me. - Deshi Xiao On 七月 30, 2016, 6 p.m., Yong Tang