Re: Review Request 56621: Updated Mesos tests to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56621/ --- (Updated Feb. 28, 2017, 7:07 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

> On Feb. 27, 2017, 12:58 p.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp, line 62 > > > > > > `static` keyword doesn't have that much use in a header. > > Greg Mann wrote: >

Re: Review Request 56624: Updated libprocess tests to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56624/ --- (Updated Feb. 28, 2017, 6:59 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56813: Updated master handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/ --- (Updated Feb. 28, 2017, 6:56 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56812: Updated agent handlers to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/ --- (Updated Feb. 28, 2017, 6:37 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56619: Updated 'Files' handlers to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/ --- (Updated Feb. 28, 2017, 6:34 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56618: Updated common Mesos code to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 28, 2017, 6:31 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56901: Updated master validation code to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56901/ --- (Updated Feb. 28, 2017, 6:30 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/ --- (Updated Feb. 28, 2017, 6:24 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56617: Updated libprocess handlers to use the 'Principal' type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56617/ --- (Updated Feb. 28, 2017, 6:21 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

> On Feb. 27, 2017, 11:58 a.m., Alexander Rojas wrote: > > 3rdparty/libprocess/include/process/authenticator.hpp, line 62 > > > > > > `static` keyword doesn't have that much use in a header. In this context, the

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 28, 2017, 6:13 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/ --- (Updated Feb. 28, 2017, 6:12 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 56611: Relax perf version check for Arch Linux.

On Feb. 26, 2017, 7:48 p.m., James Peach wrote: > > Sorry, one more thing to address and then I'll commit this: on certain > > versions of Ubuntu, `perf` is often installed but does not work correctly: > > > > ``` > > $ perf --version > > WARNING: perf not found for kernel 3.19.0-28 > > > >

Re: Review Request 56611: Relax perf version check for Arch Linux.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56611/ --- (Updated Feb. 28, 2017, 5:43 a.m.) Review request for mesos and Neil Conway.

Re: Review Request 57054: Fixed a bug in master and agent handler authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57054/ --- (Updated Feb. 28, 2017, 5:31 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review167008 --- Patch looks great! Reviews applied: [55887, 55888] Passed

Review Request 57122: Added STDIN IO to 'ContainerLogger::ContainerIO' class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57122/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-7050

Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56195/ --- (Updated Feb. 28, 2017, 5:09 a.m.) Review request for mesos, Alexander

Review Request 57121: Renamed 'ContainerLogger::SubprocessInfo' to 'ContainerIO'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57121/ --- Review request for mesos, Jie Yu and Joseph Wu. Bugs: MESOS-7050

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/#review166956 --- src/tests/containerizer/cni_isolator_tests.cpp (line 146)

Re: Review Request 55576: Speeds up FutureTest.After3 using clock manipulation utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/#review166997 --- Ship it! Patch looks good, but this says "speeds up" but isn't

Re: Review Request 56906: Dealt with a corner case in the ReadFile API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56906/#review166996 --- Patch looks great! Reviews applied: [56906] Passed command:

Re: Review Request 57093: Clears timedout timers before marking the clock as settle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57093/#review166995 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2017, 2:28

Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57108/#review166994 --- Fix it, then Ship it! Looks like we can move out the

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57106/#review166992 --- src/messages/messages.proto (lines 574 - 575)

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57106/#review166990 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2017, 10:11

Re: Review Request 57112: Updated existing test cases to allow for frameworks to change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57112/#review166982 --- Bad patch! Reviews applied: [57112, 57111, 57110, 57109, 57108]

Review Request 57118: Added debugging APIs to agent API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57118/ --- Review request for mesos, Adam B and Vinod Kone. Bugs: MESOS-7188

Review Request 57117: Added nested container launch/wait/kill APIs to agent API docs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57117/ --- Review request for mesos, Adam B, Benjamin Mahler, and Vinod Kone. Bugs:

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/ --- (Updated Feb. 28, 2017, 1:18 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/ --- (Updated Feb. 28, 2017, 1:17 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

> On Feb. 20, 2017, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > > > > > Why not TASK_ERROR? > > Anindya Sinha wrote: > AFAICT, `TASK_ERROR` is only generated from the master and never

Re: Review Request 56906: Dealt with a corner case in the ReadFile API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56906/ --- (Updated Feb. 27, 2017, 4:46 p.m.) Review request for mesos and Anand

Re: Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57106/#review166971 --- Patch looks great! Reviews applied: [57104, 57105, 57106]

Re: Review Request 56837: Added agent capabilities to HierarchicalAllocatorProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56837/#review166944 --- Ship it! include/mesos/allocator/allocator.hpp (line 179)

Re: Review Request 57023: Added a test to ensure agent could be upgrade to MULTI_ROLE capable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57023/#review166965 --- Ship it! src/tests/upgrade_tests.cpp (line 268)

Re: Review Request 57021: Added agent capabilities to `updateSlave` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57021/#review166947 --- Fix it, then Ship it!

Re: Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/#review166955 --- src/master/allocator/mesos/hierarchical.hpp (line 429)

Re: Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/#review166954 --- src/master/master.hpp (lines 2515 - 2524)

Review Request 57111: Updated the allocator to handle frameworks that change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Review Request 57112: Updated existing test cases to allow for frameworks to change its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57112/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Review Request 57110: Updated the master to handle frameworks that changes its roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57110/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Review Request 57109: Re-checkpointed the `Executor`s and `Task`s during agent recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57109/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7061

Re: Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57108/ --- (Updated Feb. 27, 2017, 2:15 p.m.) Review request for mesos and Benjamin

Re: Review Request 53264: Added test for CNI port-mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53264/ --- (Updated Feb. 27, 2017, 10:13 p.m.) Review request for mesos, Jie Yu and Qian

Review Request 57108: Handled the `FrameworkInfo` field added to the `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57108/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Review Request 57106: Added `FrameworkInfo` to `UpdateFrameworkMessage`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57106/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Re: Review Request 57105: Updated a few functions in the master to be declared `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57105/#review166953 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2017, 9:57

Re: Review Request 57104: Updated a few functions in the agent to be declared `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57104/#review166952 --- Ship it! Ship It! - Benjamin Mahler On Feb. 27, 2017, 9:57

Review Request 57105: Updated a few functions in the master to be declared `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57105/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Review Request 57104: Updated a few functions in the agent to be declared `const`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57104/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-6627

Re: Review Request 53842: Add role specific metrics for sorting runs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53842/#review166950 --- Patch looks great! Reviews applied: [53839, 53840, 53841, 53842]

Re: Review Request 49571: Added a benchmark test for allocations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49571/ --- (Updated Feb. 27, 2017, 8:50 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53839: Added a metric in the master to track sending of previous offer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53839/ --- (Updated Feb. 27, 2017, 8:18 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53840: Added a metric in the allocator to track previous allocation cycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53840/ --- (Updated Feb. 27, 2017, 8:18 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53842: Add role specific metrics for sorting runs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53842/ --- (Updated Feb. 27, 2017, 8:18 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 53841: Added metrics for sorting of the sorters in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53841/ --- (Updated Feb. 27, 2017, 8:18 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks.

> On Feb. 27, 2017, 9:36 a.m., Jie Yu wrote: > > include/mesos/slave/container_logger.hpp, line 127 > > > > > > This will probably break windows build? Nope, the `int_fd` class will handle this appropriately. -

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review166908 --- Patch looks great! Reviews applied: [53369] Passed command:

Re: Review Request 53369: Agent cgroup assignment should precede agent initialization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/ --- (Updated Feb. 27, 2017, 5:47 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review166890 --- src/slave/slave.cpp (line 1706)

Re: Review Request 56195: Fixed ContainerLogger / IOSwitchboard FD leaks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56195/#review166829 --- include/mesos/slave/container_logger.hpp (lines 104 - 106)

Re: Review Request 55790: Support the full CNI DNS specification.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55790/#review166879 --- src/tests/containerizer/cni_isolator_tests.cpp (line 116)

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 25, 2017, 1:24 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/windows_launcher.cpp, lines 50-62 > > > > > > Erm... saving the set of PIDs in a prior loop guarantees that the > >

Re: Review Request 56362: Windows: Create the Windows container launcher.

> On Feb. 25, 2017, 1:24 a.m., Joseph Wu wrote: > > This is definitely the direction we want to head towards (Job objects, > > without leaking handles). > > > > But, due to the partial duplication of logic in: > > https://reviews.apache.org/r/56366/ > > I think we should move much of this

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

> On Feb. 19, 2017, 11:07 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 1722 > > > > > > Why not TASK_ERROR? > > Anindya Sinha wrote: > AFAICT, `TASK_ERROR` is only generated from the master and

Re: Review Request 56619: Updated 'Files' handlers to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/#review166883 --- Ship it! Ship It! - Alexander Rojas On Feb. 25, 2017, 12:06

Re: Review Request 55576: Speeds up FutureTest.After3 using clock manipulation utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/#review166881 --- Patch looks great! Reviews applied: [57093, 55576] Passed

Re: Review Request 55576: Speeds up FutureTest.After3 using clock manipulation utilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55576/ --- (Updated Feb. 27, 2017, 3:35 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 55576: Fixes FutureTest.After3 flakiness.

> On Feb. 21, 2017, 9:34 p.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/clock.cpp, line 188 > > > > > > Can you pull this out into a separate patch? Broken down with first part into

Review Request 57093: Clears timedout timers before marking the clock as settle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57093/ --- Review request for mesos, Benjamin Bannier, Benjamin Hindman, Benjamin Mahler,

Re: Review Request 57054: Fixed a bug in master and agent handler authorization logic.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57054/#review166866 --- Ship it! Thanks for taking care of this! - Alexander Rojas

Re: Review Request 56901: Updated master validation code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56901/#review166862 --- Ship it! Ship It! - Alexander Rojas On Feb. 22, 2017, 8:48

Re: Review Request 56618: Updated common Mesos code to use 'AuthenticationContext'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56618/#review166854 --- Ship it! Ship It! - Alexander Rojas On Feb. 22, 2017, 2:15

Re: Review Request 56623: Implemented 'AuthenticationContext' in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56623/#review166851 --- 3rdparty/libprocess/include/process/authenticator.hpp (line 62)