Re: Review Request 60035: WIP: Added support for printing JSON values via `jsonify`.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60035/#review177708 --- 3rdparty/stout/include/stout/json.hpp Lines 711-714 (patched)

Re: Review Request 60035: WIP: Added support for printing JSON values via `jsonify`.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60035/ --- (Updated June 13, 2017, 1:31 a.m.) Review request for mesos and Benjamin Mahler

Review Request 60035: Added support for printing JSON values via `jsonify`.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60035/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 59861: Added protobuf changes for Reservation Refinement.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59861/ --- (Updated June 13, 2017, 1:30 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
> On June 9, 2017, 6:48 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 578-579 (patched) > > > > > > I wonder if we could have 0 initial delay by default for the tests so > > that you don't h

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
> On June 9, 2017, 6:48 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 610-629 (patched) > > > > > > In order to simplify this test, we could file another ticket for having > > a set of testi

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
> On June 9, 2017, 6:48 p.m., Benjamin Mahler wrote: > > src/tests/upgrade_tests.cpp > > Lines 562-576 (patched) > > > > > > This needs to come before you start the slave, no? Doesn't seem like it's possible? The `s

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
> On June 8, 2017, 11:24 a.m., Neil Conway wrote: > > src/tests/upgrade_tests.cpp > > Lines 755 (patched) > > > > > > Any particular reason we're setting `MULTI_ROLE` capability here? I think mainly because the `Fra

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
> On June 8, 2017, 11:24 a.m., Neil Conway wrote: > > src/tests/upgrade_tests.cpp > > Lines 614 (patched) > > > > > > Why `MULTI_ROLE`? I think mainly because the `FrameworkInfo.role` field is deprecated. But I've

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
> On June 6, 2017, 10:25 p.m., Benjamin Bannier wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2072-2083 (original), 2072-2093 (patched) > > > > > > While this code just extends an existing pattern

Re: Review Request 59860: Prevent allocating non-capable agents' resources to hierarchical roles.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59860/ --- (Updated June 13, 2017, 1:22 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 59859: Added `HIERARCHICAL_ROLE` agent capability.

2017-06-13 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59859/ --- (Updated June 13, 2017, 12:06 a.m.) Review request for mesos, Benjamin Mahler a

<    1   2