Re: Review Request 60397: WIP: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/#review178952 --- src/tests/environment.cpp Line 542 (original), 542-548 (patched)

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178946 --- src/slave/containerizer/mesos/containerizer.cpp Lines 323

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178945 --- Ship it! Ship It! - Hao Yixin On 六月 26, 2017, 10:39 p.m.,

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/#review178943 --- Ship it! Ship It! - haosdent huang On June 26, 2017, 10:39

Re: Review Request 60428: Added MESOS-7581 to the 1.1.3 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60428/#review178942 --- Patch looks great! Reviews applied: [60425, 60427, 60428]

Re: Review Request 54693: Add ProtoBuf schema for Blkio cgroup subsystem

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54693/ --- (Updated June 26, 2017, 10:50 p.m.) Review request for mesos, Xiaojian Huang,

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/ --- (Updated June 26, 2017, 3:39 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60170/ --- (Updated June 26, 2017, 3:37 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60169: Introduced a new agent flag 'cgroups_auto'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60169/ --- (Updated June 26, 2017, 3:36 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 60448: Forward declare CheckerProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60448/#review178934 --- Ship it! Ship It! - Gastón Kleiman On June 26, 2017, 10:18

Review Request 60448: Forward declare CheckerProcess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60448/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos

Re: Review Request 58394: Setup new directory for python http client lib in src/python.

> On May 2, 2017, 11:11 p.m., Kevin Klues wrote: > > src/python/lib/mesos/__init__.py > > Lines 1 (patched) > > > > > > I would exclude this from this commit. > > It is not used anywhere, therefore it should not

Re: Review Request 60397: WIP: Check perf version compatibility in tests with disabled coredumps.

> On June 23, 2017, 11:49 p.m., James Peach wrote: > > Great idea! What do you think about setting the core rlimit to 0 in the the > > `subprocess` clone lambda in `perf::execute()`? According to discussion in the related ticket, crashes are caused by calling abort() on failures in

Re: Review Request 60397: WIP: Check perf version compatibility in tests with disabled coredumps.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60397/ --- (Updated June 26, 2017, 8:07 p.m.) Review request for mesos, Benjamin Bannier,

Review Request 60440: Updated local development workflow of mesos website.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60440/ --- Review request for mesos and haosdent huang. Bugs: MESOS-7625

Review Request 60439: Added scripts to automate website publishing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60439/ --- Review request for mesos and haosdent huang. Bugs: MESOS-7625

Review Request 60438: Updated endpoint help generator script to work inside Docker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60438/ --- Review request for mesos, Benjamin Mahler and haosdent huang. Bugs: MESOS-7625

Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.

> On June 23, 2017, 4:06 p.m., haosdent huang wrote: > > src/webui/master/static/agent.html > > Lines 176 (patched) > > > > > > Should we use `*` here to keep consistent with other parts? There is related

Re: Review Request 60233: Linted support/post-reviews.py.

> On June 26, 2017, 11:40 a.m., Benjamin Bannier wrote: > > support/post-reviews.py > > Line 48 (original), 69 (patched) > > > > > > Do we need to name the exception here? It seems the original `raise` > > was

Re: Review Request 60426: Marked 1.2.2 as WIP in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60426/#review178900 --- Ship it! Ship It! - Adam B On June 26, 2017, 3:42 a.m.,

Re: Review Request 60234: Linted support/push-commits.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60234/ --- (Updated June 26, 2017, 3:49 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60235: Linted support/test-upgrade.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60235/ --- (Updated June 26, 2017, 3:48 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60233: Linted support/post-reviews.py.

> On June 26, 2017, 9:40 a.m., Benjamin Bannier wrote: > > support/post-reviews.py > > Line 48 (original), 69 (patched) > > > > > > Do we need to name the exception here? It seems the original `raise` > > was

Re: Review Request 60233: Linted support/post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60233/ --- (Updated June 26, 2017, 3:46 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 59746: Separated discarded and failed cases for container launch.

> On June 2, 2017, 4:37 p.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 5147 (original), 5147 (patched) > > > > > > Can you explain to me in what scenario, the `future` will be in > > DISCARDED state? who

Re: Review Request 60236: Linted support/verify-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60236/ --- (Updated June 26, 2017, 3:28 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 60008: Fixed bug causing FUTURE_DISPATCH to react on irrelevant dispatch (WIP).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60008/#review17 --- 3rdparty/libprocess/include/process/dispatch.hpp Lines 68

Re: Review Request 59294: Optionally scale egress bandwidth with CPU.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59294/#review178796 --- src/slave/containerizer/mesos/isolators/network/port_mapping.cpp

Review Request 60427: Added MESOS-7581 to the 1.2.2 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60427/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 60428: Added MESOS-7581 to the 1.1.3 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60428/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 60425: Added MESOS-7581 to the 1.3.1 CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60425/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 60426: Marked 1.2.2 as WIP in CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60426/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 60353: Allowed dashes in Python modules.

> On June 22, 2017, 10:01 a.m., Armand Grillet wrote: > > src/cli_new/pylint.config > > Lines 16 (patched) > > > > > > I do not think that having a pylint.config for all our Python > > directories in src/cli_new is

Re: Review Request 60235: Linted support/test-upgrade.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60235/#review178877 --- Fix it, then Ship it! support/test-upgrade.py Lines 34

Re: Review Request 60234: Linted support/push-commits.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60234/#review178875 --- Fix it, then Ship it! support/push-commits.py Lines 20

Re: Review Request 60233: Linted support/post-reviews.py.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60233/#review178874 --- Fix it, then Ship it! support/post-reviews.py Line 20

Review Request 60423: Renamed method `resources` to `allocatedResources` in master::Role.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60423/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 58552: Resolved a TODO of MULTI_ROLE.

> On June 26, 2017, 2:55 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Line 2838 (original), 2838-2839 (patched) > > > > > > Rather than the comment, we should just call this function > >

Re: Review Request 58202: Tweaked an incorrect comment in allocator test.

> On June 26, 2017, 7 a.m., Benjamin Mahler wrote: > > Ship It! I changed the summary to: "Fixed an incorrect comment about MULTI_ROLE in the allocator tests." - Benjamin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58202: Tweaked an incorrect comment in allocator test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58202/#review178865 --- Ship it! Ship It! - Benjamin Mahler On April 5, 2017, 8:56

Re: Review Request 58552: Resolved a TODO of MULTI_ROLE.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58552/#review178864 --- Fix it, then Ship it! src/master/master.hpp Line 2838