Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`.

2017-12-27 Thread Michael Park
> On Dec. 19, 2017, 6:13 p.m., Benjamin Mahler wrote: > > The "upgrade" vs "normalize" inconsistency seems a little odd? I'll follow up with a patch to change "normalize" to "upgrade". Seems more fitting with the presence of "downgrade". - Michael

Review Request 64848: Updated example frameworks to make use of added flags.

2017-12-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64848/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil

Review Request 64847: Added collection of example framework flag definitions.

2017-12-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64847/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil

Review Request 64857: Updated example frameworks for mesos-local.

2017-12-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64857/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil

Review Request 64846: Updated example frameworks environment parameter prefix.

2017-12-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64846/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil

Review Request 64849: Added authentication to some example frameworks.

2017-12-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64849/ --- Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, Kapil

Re: Review Request 64856: Fixed resource provider driver disconnection handling.

2017-12-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64856/#review194550 --- Ship it! Thank you for cleaning this up Jie. - Benjamin

Review Request 64856: Fixed resource provider driver disconnection handling.

2017-12-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64856/ --- Review request for mesos, Benjamin Bannier and Jan Schlicht. Bugs: MESOS-8349

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

2017-12-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/#review194533 --- Fix it, then Ship it! include/mesos/agent/agent.proto Lines

Re: Review Request 64812: Added `excluded_images` parameter to `PRUNE_IMAGES` agent API.

2017-12-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64812/#review194546 --- Ship it! Ship It! - Gilbert Song On Dec. 23, 2017, 5:21

Re: Review Request 64770: Fixed a potential race condition in the test infrastructure.

2017-12-27 Thread Andrei Budnik
> On Dec. 22, 2017, 3:38 a.m., Greg Mann wrote: > > This looks like a reasonable solution to me. However, it would be great if > > we could reproduce the bug and then verify the fix. Looking at the log of a > > failed test run in the JIRA, it seems to me that the problem occurs when > >