Re: Review Request 65683: Added discard handling to Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/#review197661 --- PASS: Mesos patch 65683 was successfully built and tested.

Review Request 65683: Added discard handling to Docker library functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65683/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Repository: mesos

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review197658 --- Patch looks great! Reviews applied: [65679] Passed command:

Re: Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review197656 --- PASS: Mesos patch 65679 was successfully built and tested.

Re: Review Request 65315: Removed a redundant authorization helper class from the tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65315/#review197655 --- Ship it! Ship It! - Gaston Kleiman On Jan. 30, 2018, 6:52

Review Request 65679: Removed direct unmock calls and added missing mock call expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/ --- Review request for mesos, Chun-Hung Hsiao and Greg Mann. Repository: mesos

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/#review197652 --- src/master/master.hpp Lines 279-290 (patched)

Re: Review Request 65575: Removed redundant comment from the command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65575/#review197654 --- Ship it! Ship It! - Greg Mann On Feb. 8, 2018, 7:49 p.m.,

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review197651 --- src/master/master.cpp Lines 7652 (patched)

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

> On Feb. 15, 2018, 11:55 p.m., Greg Mann wrote: > > src/master/master.cpp > > Lines 7647-7654 (patched) > > > > > > I'm sitting here trying to think of ways we might avoid crashing if the > > framework subscribes

Re: Review Request 65482: Improved handling of non-terminal operations after master failover.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65482/#review197641 --- src/master/master.cpp Lines 7643 (patched)

Re: Review Request 65503: Added bootstrap-table library for the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65503/#review197634 --- Ship it! Ship It! - Benjamin Mahler On Feb. 11, 2018, 4:15

Re: Review Request 65503: Added bootstrap-table library for the WebUI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65503/#review197633 --- src/Makefile.am Lines 1785-1786 (original), 1785-1786 (patched)

Re: Review Request 65503: Added bootstrap-table library for the WebUI.

> On Feb. 6, 2018, 3:26 a.m., Benjamin Mahler wrote: > > Looks good, couple of questions: > > > > (1) Doesn't this need to be part of the installation? I think you need to > > update the autotools and cmake builds? > > (2) Do we need to update LICENSE to include this new sub-component? > >

Re: Review Request 65246: Added download button for master and agent logs in Web UI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65246/#review197631 --- src/webui/master/static/js/controllers.js Lines 578-585

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review197622 --- Bad patch! Reviews applied: [65674, 65673, 65591, 65590, 65589,

Re: Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/#review197621 --- FAIL: Failed to apply the dependent review: 65589. Failed

Review Request 65673: Added evolve function for mesos UUID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65673/ --- Review request for mesos, Greg Mann and Jan Schlicht. Repository: mesos

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

> On Feb. 13, 2018, 10:52 a.m., Jan Schlicht wrote: > > src/common/protobuf_utils.cpp > > Line 467 (original), 467 (patched) > > > > > > How about we create a helper function `mesos::UUID createRandomUUID()` > > in

Re: Review Request 65588: Used proto UUID instead stout UUID internally for operation IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65588/ --- (Updated Feb. 15, 2018, 3:54 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65591: Explicitly tracked resource providers in master.

> On Feb. 13, 2018, 5:30 p.m., Jan Schlicht wrote: > > src/master/master.cpp > > Lines 7334-7336 (patched) > > > > > > You compare operations here for resource providers. This isn't done in > > the code above for

Review Request 65674: Introduced helper for creating Mesos UUIDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65674/ --- Review request for mesos and Jan Schlicht. Repository: mesos Description

Re: Review Request 65591: Explicitly tracked resource providers in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65591/ --- (Updated Feb. 15, 2018, 3:54 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 65656: Removed unnecessary compiler flag in build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65656/#review197620 --- PASS: Mesos patch 65656 was successfully built and tested.

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/#review197617 --- PASS: Mesos patch 65314 was successfully built and tested.

Re: Review Request 65656: Removed unnecessary compiler flag in build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65656/ --- (Updated Feb. 15, 2018, 1:40 p.m.) Review request for mesos and Till

Re: Review Request 65656: Removed unnecessary compiler flag in build instructions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65656/#review197615 --- Fix it, then Ship it! docs/building.md Line 103 (original),

Re: Review Request 65314: Removed code which is not used.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65314/ --- (Updated Feb. 15, 2018, 2:04 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 65044: Added the v1 API 'GET_OPERATIONS' call for master and agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/ --- (Updated Feb. 15, 2018, 11:19 a.m.) Review request for mesos, Benjamin

Review Request 65672: Added comparison operators for 'v1::UUID'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65672/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-8424

Review Request 65671: Added comparison operators for operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65671/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-8424