Re: Review Request 68266: Added a benchmark for Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68266/#review206970 --- PASS: Mesos patch 68266 was successfully built and tested.

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68266/ --- (Updated Aug. 8, 2018, 4:59 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68266/ --- (Updated Aug. 8, 2018, 4:33 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 68266: Added a benchmark for Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68266/ --- (Updated Aug. 8, 2018, 4:26 a.m.) Review request for mesos, Benjamin Mahler

Review Request 68266: Added a benchmark for Mesos containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68266/ --- Review request for mesos, Benjamin Mahler and Gilbert Song. Repository: mesos

Re: Review Request 68022: Enabled Seccomp filter in the containerizer launcher.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68022/#review206965 --- Bad patch! Reviews applied: [68022, 68021, 68020, 68019, 68018,

Re: Review Request 68265: Built gRPC support in mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68265/#review206964 --- PASS: Mesos patch 68265 was successfully built and tested.

Re: Review Request 68175: Windows: Change strings in Windows os code to `wstring`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68175/#review206963 --- Patch looks great! Reviews applied: [68174, 68175] Passed

Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review206962 --- Just a high level comment, it's unfortunate that this test

Review Request 68265: Built gRPC support in mesos-tidy.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68265/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, and Michael

Re: Review Request 68224: Augmented `Statistics` to work with any collection.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68224/#review206961 --- Can we just have a single function instead of keeping the

Re: Review Request 68132: Batch '/state' requests on Master.

> On Aug. 1, 2018, 12:42 a.m., Benjamin Mahler wrote: > > A couple of comments on the benchmark information before looking at the > > code, these probably belong on the previous review, but since the numbers > > are only shown in this one I'll leave these here: > > > > * Can we compare

Re: Review Request 68262: Removed unused operator overloads in `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68262/#review206959 --- Ship it! Ship It! - Benjamin Mahler On Aug. 7, 2018, 7:45

Re: Review Request 68123: Avoided unnecessary `Resources::allocations()` call in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68123/#review206958 --- Bad patch! Reviews applied: [68123, 68122, 68138, 67444, 68119,

Re: Review Request 68262: Removed unused operator overloads in `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68262/#review206956 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 68263: Fixed Windows build break due to missing lambda capture.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68263/ --- Review request for mesos and James Peach. Repository: mesos Description

Review Request 68262: Removed unused operator overloads in `Resources`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68262/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review206954 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/#review206953 --- Patch looks great! Reviews applied: [67502, 67503, 67504, 67505]

Re: Review Request 67505: Refactored verify-reviews.py to use commons.py and argparse.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67505/ --- (Updated Aug. 7, 2018, 5:37 p.m.) Review request for mesos, Andrew

Re: Review Request 67503: Added support helper for fetching review ids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67503/ --- (Updated Aug. 7, 2018, 5:36 p.m.) Review request for mesos, Andrew

Re: Review Request 67504: Added support script to post build results.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67504/ --- (Updated Aug. 7, 2018, 5:37 p.m.) Review request for mesos, Andrew

Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67502/ --- (Updated Aug. 7, 2018, 5:36 p.m.) Review request for mesos, Andrew

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

> On Aug. 7, 2018, 4:03 p.m., Vinod Kone wrote: > > src/slave/containerizer/mesos/utils.cpp > > Line 102 (original), 105 (patched) > > > > > > Are we guaranteed that there are no short-lived processes, other than >

Re: Review Request 68250: Pass compiler/linker flags when building the gRPC bundle in Mesos.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68250/#review206950 --- Ship it! Ship It! - James Peach On Aug. 7, 2018, 2:36 a.m.,

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/#review206949 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68251: Pass compiler/linker flags when building the gRPC bundle in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68251/#review206945 --- Ship it! 3rdparty/libprocess/3rdparty/Makefile.am Line 130

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68257/#review206947 --- src/slave/containerizer/mesos/utils.cpp Line 102 (original), 105

Re: Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68257/#review206946 --- PASS: Mesos patch 68257 was successfully built and tested.

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68222/ --- (Updated Aug. 7, 2018, 10:24 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68221: Updated `docker/volume` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68221/ --- (Updated Aug. 7, 2018, 10:23 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68220: Updated the test `ROOT_SecretInVolumeWithRootFilesystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68220/ --- (Updated Aug. 7, 2018, 10:23 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68218: Added a test `ROOT_ImageInReadOnlyVolumeWithoutRootFilesystem`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68218/ --- (Updated Aug. 7, 2018, 10:22 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68219: Updated `volume/secret` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68219/ --- (Updated Aug. 7, 2018, 10:22 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68216: Updated `volume/image` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68216/ --- (Updated Aug. 7, 2018, 10:20 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68215: Added a test `VolumeSandboxPathIsolatorTest.ROOT_SelfTypeReadOnly`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68215/ --- (Updated Aug. 7, 2018, 10:19 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68214/ --- (Updated Aug. 7, 2018, 10:18 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68213: Added a test `VolumeHostPathIsolatorTest.ROOT_ReadOnlyVolumeFromHost`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68213/ --- (Updated Aug. 7, 2018, 10:11 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68203: Updated volume isolators to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68203/ --- (Updated Aug. 7, 2018, 10:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 68212: Updated `volume/host_path` isolator to honor volume mode.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68212/ --- (Updated Aug. 7, 2018, 10:09 p.m.) Review request for mesos, Gilbert Song,

Review Request 68256: Added `LaunchNestedContainerSessionInParallel` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68256/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin

Review Request 68257: Fixed incorrect `mnt` namespace detection of command executor's task.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68257/ --- Review request for mesos, Alexander Rukletsov, Gilbert Song, Jie Yu, and Kevin

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/#review206942 --- PASS: Mesos patch 68132 was successfully built and tested.

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 7, 2018, 12:11 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 7, 2018, 12:10 p.m.) Review request for mesos, Benno Evers and

Re: Review Request 68132: Batch '/state' requests on Master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68132/ --- (Updated Aug. 7, 2018, 11:31 a.m.) Review request for mesos, Benno Evers and

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68229/#review206937 --- PASS: Mesos patch 68229 was successfully built and tested.

Re: Review Request 68229: Removed unused local variable in `slave.cpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68229/ --- (Updated Aug. 7, 2018, 9:36 a.m.) Review request for mesos and Alexander

Re: Review Request 67932: Windows: Extracted file layers using `wclayer` from `hcsshim`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67932/#review206934 --- PASS: Mesos patch 67932 was successfully built and tested.

Re: Review Request 68251: Pass compiler/linker flags when building the gRPC bundle in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68251/#review206933 --- PASS: Mesos patch 68251 was successfully built and tested.