Re: Review Request 69003: Added `task exec` to new CLI.

2018-10-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69003/#review209515 --- PASS: Mesos patch 69003 was successfully built and tested.

Review Request 69007: Added `get_container_id` to util functions for the new CLI.

2018-10-13 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69007/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-6551

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

2018-10-13 Thread Chun-Hung Hsiao
> On Oct. 13, 2018, 2:49 a.m., James DeFelice wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > Why is the default `false` here? If someone is calling the `checkpoint` > > func