Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 11, 2019, 7:30 a.m., Gilbert Song wrote: > > Could we vertify the CI failure above `SlaveRecoveryTest/0.Reboot` is not > > caused by our change? Actually it is caused by this patch :-( And I have fixed it in this patch: https://reviews.apache.org/r/69716/ . - Qian

Review Request 69716: Updated `SlaveRecoveryTest.Reboot` to expect none pids.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69716/ --- Review request for mesos, Andrei Budnik, Gilbert Song, and Vinod Kone. Bugs:

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211864 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 10:14

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

> On Jan. 11, 2019, 7:29 a.m., Gilbert Song wrote: > > src/slave/state.cpp > > Line 561 (original), 592 (patched) > > > > > > Could we confirm we do not care about this marker case after reboot? After reboot, the

Re: Review Request 69713: Fixed a bug in health_check_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69713/#review211862 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 9:34

Re: Review Request 69714: Fixed a bug in docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69714/#review211863 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 10:14

Re: Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69711/#review211861 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 9:13

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/#review211859 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 9:13

Re: Review Request 69713: Fixed a bug in health_check_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69713/#review211858 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/ --- Review request for mesos, Deepak Goel, Gilbert Song, and Qian Zhang. Bugs:

Review Request 69714: Fixed a bug in docker_containerizer_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69714/ --- Review request for mesos, Deepak Goel, Gilbert Song, and Qian Zhang.

Re: Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211856 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 69713: Fixed a bug in health_check_tests.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69713/ --- Review request for mesos and Qian Zhang. Repository: mesos Description

Re: Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/#review211855 --- PASS: Mesos patch 69708 was successfully built and tested.

Re: Review Request 69710: Switched to use ContainerizerTest for CNI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/ --- (Updated Jan. 11, 2019, 5:13 a.m.) Review request for mesos, Deepak Goel,

Re: Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69711/ --- (Updated Jan. 11, 2019, 5:13 a.m.) Review request for mesos, Deepak Goel,

Review Request 69710: Switched to use ContainerizerTest for CNI tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69710/ --- Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian

Review Request 69711: Separated runtime dirs from other dirs in MesosTest.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69711/ --- Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian

Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/ --- Review request for mesos, Deepak Goel, Gilbert Song, James Peach, and Qian

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/ --- (Updated Jan. 11, 2019, 5:08 a.m.) Review request for mesos, Deepak Goel,

Review Request 69708: Fixed gRPC CMake build issue on Ubuntu 14.04.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69708/ --- Review request for mesos and Gastón Kleiman. Bugs: MESOS-9519

Re: Review Request 69694: Tester.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69694/#review211851 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211845 --- Could we vertify the CI failure above

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211844 --- Ship it! src/slave/state.cpp Line 561 (original), 592

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211842 --- Ship it! Ship It! - Deepak Goel On Jan. 10, 2019, 8:44

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211841 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211840 --- Ship it! Ship It! - Gilbert Song On Jan. 10, 2019, 12:44

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211838 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 69669: Notified frameworks when operations are marked as unreachable.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69669/#review211836 --- src/master/master.cpp Line 8954 (original), 8982-8984 (patched)

Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/ --- Review request for mesos, Deepak Goel, James Peach, and Qian Zhang. Bugs:

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211831 --- src/slave/slave.cpp Lines 6183 (patched)

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211830 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/#review211829 --- Can you write a unit test for this by spoofing the reboot? -

Review Request 69705: Made agent not read the forked pid and libprocess pid after reboot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69705/ --- Review request for mesos, Andrei Budnik and Gilbert Song. Bugs: MESOS-9501

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/#review211825 --- PASS: Mesos patch 69662 was successfully built and tested.

Re: Review Request 69337: Garbage collected disappeared resource providers from master state.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69337/ --- (Updated Jan. 10, 2019, 11:29 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

> On Jan. 9, 2019, 11:19 p.m., Chun-Hung Hsiao wrote: > > src/webui/app/controllers.js > > Lines 697 (patched) > > > > > > Instead of setting `agent.resource_providers` with > > `state.resource_providers` and

Re: Review Request 69662: Displayed resource provider information in the Mesos webui.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69662/ --- (Updated Jan. 10, 2019, 10:19 a.m.) Review request for mesos, Armand Grillet,